Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1962853002:
[es8] Prepare explicit tail calls (STC) for staging with implicit tail calls (PTC). (Closed)
|
Created:
4 years, 7 months ago by Igor Sheludko Modified:
4 years, 7 months ago Reviewers:
rossberg CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@src-stage Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[es8] Prepare explicit tail calls (STC) for staging with implicit tail calls (PTC).
BUG=v8:4915
LOG=N
Committed: https://crrev.com/aa006f644bc7d6441e9af7e94eeb88c8674863d3
Cr-Commit-Position: refs/heads/master@{#36129}
Patch Set 1 : #
Total comments: 2
Patch Set 2 : Addressing comments #
Messages
Total messages: 36 (22 generated)
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962853002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ishell@chromium.org changed reviewers: + rossberg@chromium.org
PTAL
lgtm https://codereview.chromium.org/1962853002/diff/20001/src/parsing/parser-base.h File src/parsing/parser-base.h (right): https://codereview.chromium.org/1962853002/diff/20001/src/parsing/parser-base... src/parsing/parser-base.h:212: void AddProperTailCall(ExpressionT expr) { expressions_.Add(expr, zone_); } Nit: How about naming these Implicit vs Explicit tail calls? (Given that there is nothing improper about "syntactic" ones, nor anything non-syntactic about "proper" ones.)
Patchset #2 (id:40001) has been deleted
https://codereview.chromium.org/1962853002/diff/20001/src/parsing/parser-base.h File src/parsing/parser-base.h (right): https://codereview.chromium.org/1962853002/diff/20001/src/parsing/parser-base... src/parsing/parser-base.h:212: void AddProperTailCall(ExpressionT expr) { expressions_.Add(expr, zone_); } On 2016/05/10 09:21:57, rossberg wrote: > Nit: How about naming these Implicit vs Explicit tail calls? (Given that there > is nothing improper about "syntactic" ones, nor anything non-syntactic about > "proper" ones.) Done.
The CQ bit was checked by ishell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rossberg@chromium.org Link to the patchset: https://codereview.chromium.org/1962853002/#ps60001 (title: "Addressing comments")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 1964643002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== [es8] Prepare syntactic tail calls for staging with proper tail calls. BUG=v8:4915 LOG=N ========== to ========== [es8] Prepare explicit tail calls (STC) for staging with implicit tail calls (PTC). BUG=v8:4915 LOG=N ==========
The CQ bit was checked by ishell@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 1964643002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Patchset #2 (id:60001) has been deleted
The CQ bit was checked by ishell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rossberg@chromium.org Link to the patchset: https://codereview.chromium.org/1962853002/#ps80001 (title: "Addressing comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962853002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962853002/80001
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Patchset #2 (id:80001) has been deleted
The CQ bit was checked by ishell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rossberg@chromium.org Link to the patchset: https://codereview.chromium.org/1962853002/#ps100001 (title: "Addressing comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962853002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962853002/100001
Message was sent while issue was closed.
Description was changed from ========== [es8] Prepare explicit tail calls (STC) for staging with implicit tail calls (PTC). BUG=v8:4915 LOG=N ========== to ========== [es8] Prepare explicit tail calls (STC) for staging with implicit tail calls (PTC). BUG=v8:4915 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #2 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [es8] Prepare explicit tail calls (STC) for staging with implicit tail calls (PTC). BUG=v8:4915 LOG=N ========== to ========== [es8] Prepare explicit tail calls (STC) for staging with implicit tail calls (PTC). BUG=v8:4915 LOG=N Committed: https://crrev.com/aa006f644bc7d6441e9af7e94eeb88c8674863d3 Cr-Commit-Position: refs/heads/master@{#36129} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/aa006f644bc7d6441e9af7e94eeb88c8674863d3 Cr-Commit-Position: refs/heads/master@{#36129} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
