src/parsing/preparser.cc - Issue 1962853002: [es8] Prepare explicit tail calls (STC) for staging with implicit tail calls (PTC).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/preparser.cc

Issue 1962853002: [es8] Prepare explicit tail calls (STC) for staging with implicit tail calls (PTC). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@src-stage

Patch Set: Addressing comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parsing/preparser.cc

diff --git a/src/parsing/preparser.cc b/src/parsing/preparser.cc

index 68372f841a7ea7811129db20ff93046c174dbbf2..5bf5eb423200e80099d055dc5fd765a7f7698b16 100644

--- a/src/parsing/preparser.cc

+++ b/src/parsing/preparser.cc

@@ -1015,7 +1015,7 @@ PreParser::Statement PreParser::ParseTryStatement(bool* ok) {

Consume(Token::FINALLY);

ParseBlock(CHECK_OK);

if (FLAG_harmony_explicit_tailcalls && catch_block_exists &&

- !tail_call_expressions_in_catch_block.is_empty()) {

+ tail_call_expressions_in_catch_block.has_explicit_tail_calls()) {

// TODO(ishell): update chapter number.

// ES8 XX.YY.ZZ

ReportMessageAt(tail_call_expressions_in_catch_block.location(),

« no previous file with comments | « src/parsing/parser-base.h ('k') | no next file » | no next file with comments »