Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 196283013: Make to call WebContentsImpl::RenderViewCreated() when we create child window. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« AUTHORS ('K') | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
===================================================================
--- content/browser/web_contents/web_contents_impl.cc (revision 256801)
+++ content/browser/web_contents/web_contents_impl.cc (working copy)
@@ -1377,6 +1377,7 @@
if (params.disposition == NEW_BACKGROUND_TAB)
create_params.initially_hidden = true;
new_contents->Init(create_params);
+ new_contents->RenderViewCreated(new_contents->GetRenderViewHost());
sky 2014/03/19 15:41:31 This should be invoked from RenderViewHostImpl. Is
Charlie Reis 2014/03/19 23:31:59 Agreed, this is not the right place for this call.
// Save the window for later if we're not suppressing the opener (since it
// will be shown immediately).
« AUTHORS ('K') | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698