Make to call WebContentsImpl::RenderViewCreated() when we create child window.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 1359 matching lines @@
     WebContentsImpl* new_contents_impl =
         static_cast<WebContentsImpl*>(new_contents);
     BrowserPluginGuest::CreateWithOpener(instance_id,
                                          new_contents_impl->opener() != NULL,
                                          new_contents_impl,
                                          GetBrowserPluginGuest());
   }
   if (params.disposition == NEW_BACKGROUND_TAB)
     create_params.initially_hidden = true;
   new_contents->Init(create_params);
+  new_contents->RenderViewCreated(new_contents->GetRenderViewHost());

[sky, 2014/03/19 15:41:31]

This should be invoked from RenderViewHostImpl. Is there a reason it isn't
happening here?

[Charlie Reis, 2014/03/19 23:31:59]

Agreed, this is not the right place for this call.  Please do not land this.

If you're not seeing it called, it sounds like you may be missing the call to
RenderViewHostImpl::CreateRenderView.

 
   // Save the window for later if we're not suppressing the opener (since it
   // will be shown immediately).
   if (!params.opener_suppressed) {
     if (!is_guest) {
       WebContentsViewPort* new_view = new_contents->view_.get();
 
       // TODO(brettw): It seems bogus that we have to call this function on the
       // newly created object and give it one of its own member variables.
       new_view->CreateViewForWidget(new_contents->GetRenderViewHost());
@@ skipping 2237 matching lines @@
 
 void WebContentsImpl::OnPreferredSizeChanged(const gfx::Size& old_size) {
   if (!delegate_)
     return;
   const gfx::Size new_size = GetPreferredSize();
   if (new_size != old_size)
     delegate_->UpdatePreferredSize(this, new_size);
 }
 
 }  // namespace content