Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: test/browser/language_tests.js

Issue 1962823002: fix #552, Object members on native types (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/compiler/nullable_type_inference.dart ('k') | test/codegen/corelib/type_hashcode_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browser/language_tests.js
diff --git a/test/browser/language_tests.js b/test/browser/language_tests.js
index b9949dd979d1b472b7f81bb6d6b08a267450ab83..56699055bd04206ad87a7bb9c6dce93d2e47a0bb 100644
--- a/test/browser/language_tests.js
+++ b/test/browser/language_tests.js
@@ -84,6 +84,10 @@
'cha_deopt1_test': skip_fail,
'cha_deopt2_test': skip_fail,
'cha_deopt3_test': skip_fail,
+
+ // interpolation does not call Dart's toString:
+ // https://github.com/dart-lang/dev_compiler/issues/470
+ 'class_syntax2_test': skip_fail,
'classes_static_method_clash_test': skip_fail,
'closure_call_wrong_argument_count_negative_test': skip_fail,
'closure_in_constructor_test': skip_fail,
@@ -426,7 +430,6 @@
'list_replace_range_test': fail,
'list_set_all_test': fail,
'list_to_string2_test': fail,
- 'list_to_string_test': fail,
'main_test': fail,
'map_keys2_test': fail,
'map_to_string_test': fail,
@@ -454,6 +457,11 @@
},
'lib/convert': {
+ // TODO(jmesserly): this could be a failure we didn't notice before
+ // because we now call the right Dart double.toString, resulting in a
+ // difference between -0.0 and 0?
+ 'chunked_conversion_json_encode1_test': skip_fail,
+
// TODO(rnystrom): A lot of the convert tests timeout. Some do pass if
// you increase the time by a large amount, but it's pretty gratuitous.
// I'm not sure why they are so slow. One guess is that they are spewing
@@ -717,7 +725,7 @@
return null;
} catch (e) {
return e;
- };
+ }
}
test(name, function(done) { // 'function' to allow `this.timeout`.
« no previous file with comments | « lib/src/compiler/nullable_type_inference.dart ('k') | test/codegen/corelib/type_hashcode_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698