Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2509)

Unified Diff: lib/src/compiler/nullable_type_inference.dart

Issue 1962823002: fix #552, Object members on native types (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/compiler/code_generator.dart ('k') | test/browser/language_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/compiler/nullable_type_inference.dart
diff --git a/lib/src/compiler/nullable_type_inference.dart b/lib/src/compiler/nullable_type_inference.dart
index f930333ed6fd3dbde59e14def4febf222b65e664..0cbfd4ccd728cd30ee3841a696b6c834a9617331 100644
--- a/lib/src/compiler/nullable_type_inference.dart
+++ b/lib/src/compiler/nullable_type_inference.dart
@@ -23,7 +23,7 @@ import 'element_helpers.dart' show getStaticType, isInlineJS;
abstract class NullableTypeInference {
LibraryElement dartCoreLibrary;
bool isPrimitiveType(DartType type);
- bool isObjectProperty(String name);
+ bool isObjectMember(String name);
/// Known non-null local variables.
HashSet<LocalVariableElement> _notNullLocals;
@@ -102,7 +102,7 @@ abstract class NullableTypeInference {
return false;
}
// We encountered a non-Object method/property.
- if (e != null && !isObjectProperty(e.name)) {
+ if (e != null && !isObjectMember(e.name)) {
return false;
}
}
« no previous file with comments | « lib/src/compiler/code_generator.dart ('k') | test/browser/language_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698