Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: BMPDecoder + remove partial Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h
diff --git a/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h b/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h
index 05fff2ecdc2786020b8829daa16fd3241bf81bc8..ee8a2d09e0cfaa9574c133666a58a4d18ab969b2 100644
--- a/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h
+++ b/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h
@@ -92,9 +92,13 @@ public:
return m_client->repetitionCount();
}
- bool frameIsCompleteAtIndex(size_t) const override
+ bool frameIsFullyReceivedAtIndex(size_t index) const override
{
- return m_client->status() == ImageFrame::FrameComplete;
+ // All but the last frame are fully received.
+ // For the last frame use bse class implementation.
scroggo_chromium 2016/05/16 20:32:08 nit: base*
aleksandar.stojiljkovic 2016/05/22 15:41:53 Done.
+ if (index < const_cast<MockImageDecoder*>(this)->frameCount() - 1)
+ return true;
+ return ImageDecoder::frameIsFullyReceivedAtIndex(index);
}
float frameDurationAtIndex(size_t) const override

Powered by Google App Engine
This is Rietveld 408576698