Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h

Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: BMPDecoder + remove partial Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h
diff --git a/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h
index d150a56bb5a874a98d140a44c218e9b5d9333258..efe4dbb0f853a58695cf392bc6cc597f18ffefdf 100644
--- a/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h
+++ b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h
@@ -355,6 +355,11 @@ private:
bool m_seenNonZeroAlphaPixel;
bool m_seenZeroAlphaPixel;
+ // Variables m_seenNonZeroAlphaPixel and m_seenZeroAlphaPixel are tracking
+ // values used for alpha channel. m_hasPixelsWithAlpha tracks if decoding
+ // saw pixels that are transparent.
scroggo_chromium 2016/05/16 20:32:08 I think this comment is confusing. It describes th
aleksandar.stojiljkovic 2016/05/22 15:41:53 reverted the code.
+ bool m_hasPixelsWithAlpha;
+
// BMPs-in-ICOs have a few differences from standalone BMPs, so we need to
// know if we're in an ICO container.
bool m_isInICO;

Powered by Google App Engine
This is Rietveld 408576698