Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1962443002:
[DevTools] Fix completions for "Object." (Closed)
|
Created:
4 years, 7 months ago by kozy Modified:
4 years, 7 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Fix completions for "Object."
Added missing condition to getCompletions.
BUG=609468
R=lushnikov@chromium.org
Committed: https://crrev.com/1130f3bf59818cd91a7a74c37b5b75277dc5ff98
Cr-Commit-Position: refs/heads/master@{#392318}
Patch Set 1 #
Messages
Total messages: 33 (17 generated)
Description was changed from ========== [DevTools] Fix completions for Object. Added missing condition to getCompletions. BUG=609468 R=lushnikov@chromium.org ========== to ========== [DevTools] Fix completions for "Object." Added missing condition to getCompletions. BUG=609468 R=lushnikov@chromium.org ==========
Andrey, please take a look!
The CQ bit was checked by lushnikov@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962443002/1
The CQ bit was unchecked by lushnikov@chromium.org
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962443002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kozyatinskiy@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962443002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962443002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kozyatinskiy@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962443002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962443002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kozyatinskiy@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962443002/1
kozyatinskiy@chromium.org changed reviewers: - kozyatinskiy@google.com
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Fix completions for "Object." Added missing condition to getCompletions. BUG=609468 R=lushnikov@chromium.org ========== to ========== [DevTools] Fix completions for "Object." Added missing condition to getCompletions. BUG=609468 R=lushnikov@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Fix completions for "Object." Added missing condition to getCompletions. BUG=609468 R=lushnikov@chromium.org ========== to ========== [DevTools] Fix completions for "Object." Added missing condition to getCompletions. BUG=609468 R=lushnikov@chromium.org Committed: https://crrev.com/1130f3bf59818cd91a7a74c37b5b75277dc5ff98 Cr-Commit-Position: refs/heads/master@{#392318} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1130f3bf59818cd91a7a74c37b5b75277dc5ff98 Cr-Commit-Position: refs/heads/master@{#392318} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
