third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js - Issue 1962443002: [DevTools] Fix completions for "Object."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 1962443002: [DevTools] Fix completions for "Object." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

index 06707525537213f061dd69d2526a69aea02ac564..1effc865e7722bb1b968c92473906386a6cf99b9 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

@@ -594,7 +594,7 @@ WebInspector.ExecutionContext.prototype = {

{

if (!object)

receivedPropertyNames.call(this, null);

- else if (object.type === "object")

+ else if (object.type === "object" || object.type === "function")

object.callFunctionJSON(getCompletions, [WebInspector.RemoteObject.toCallArgument(object.subtype)], receivedPropertyNames.bind(this));

else if (object.type === "string" || object.type === "number" || object.type === "boolean")

this.evaluate("(" + getCompletions + ")(\"" + result.type + "\")", "completion", false, true, true, false, false, receivedPropertyNamesFromEval.bind(this));

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/console-cd-completions-expected.txt ('k') | no next file » | no next file with comments »