Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196243010: Remove use of a V8 handle outside of bindings code in TimingInput.cpp. (Closed)

Created:
6 years, 9 months ago by rmacnak
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, siva
Visibility:
Public.

Description

Remove use of a V8 handle outside of bindings code in TimingInput.cpp. R=alancutter@chromium.org, jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169893

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/core/animation/TimingInput.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
rmacnak
6 years, 9 months ago (2014-03-21 19:41:33 UTC) #1
alancutter (OOO until 2018)
lgtm
6 years, 9 months ago (2014-03-24 00:34:29 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-24 12:15:54 UTC) #3
rmacnak
The CQ bit was checked by rmacnak@google.com
6 years, 9 months ago (2014-03-24 16:56:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmacnak@google.com/196243010/1
6 years, 9 months ago (2014-03-24 16:56:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 18:00:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-24 18:00:36 UTC) #7
rmacnak
The CQ bit was checked by rmacnak@google.com
6 years, 9 months ago (2014-03-24 20:12:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmacnak@google.com/196243010/20001
6 years, 9 months ago (2014-03-24 20:12:26 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 21:19:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 21:19:44 UTC) #11
rmacnak
Committed manually as r169876. With wrong commit message :(
6 years, 9 months ago (2014-03-24 21:41:00 UTC) #12
rmacnak
On 2014/03/24 21:41:00, Ryan Macnak wrote: > Committed manually as r169876. > > With wrong ...
6 years, 9 months ago (2014-03-24 22:06:35 UTC) #13
rmacnak
6 years, 9 months ago (2014-03-25 00:09:15 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 manually as r169893 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698