Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Side by Side Diff: Source/core/animation/TimingInput.cpp

Issue 196243010: Remove use of a V8 handle outside of bindings code in TimingInput.cpp. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/animation/TimingInput.h" 6 #include "core/animation/TimingInput.h"
7 7
8 #include "bindings/v8/Dictionary.h" 8 #include "bindings/v8/Dictionary.h"
9 #include "core/css/parser/BisonCSSParser.h" 9 #include "core/css/parser/BisonCSSParser.h"
10 #include "core/css/resolver/CSSToStyleMap.h" 10 #include "core/css/resolver/CSSToStyleMap.h"
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 setFillMode(result, fillMode); 120 setFillMode(result, fillMode);
121 121
122 double iterationStart = 0; 122 double iterationStart = 0;
123 timingInputDictionary.get("iterationStart", iterationStart); 123 timingInputDictionary.get("iterationStart", iterationStart);
124 setIterationStart(result, iterationStart); 124 setIterationStart(result, iterationStart);
125 125
126 double iterationCount = 1; 126 double iterationCount = 1;
127 timingInputDictionary.get("iterations", iterationCount); 127 timingInputDictionary.get("iterations", iterationCount);
128 setIterationCount(result, iterationCount); 128 setIterationCount(result, iterationCount);
129 129
130 v8::Local<v8::Value> iterationDurationValue; 130 double iterationDuration = 0;
131 if (timingInputDictionary.get("duration", iterationDurationValue)) { 131 if (timingInputDictionary.get("duration", iterationDuration)) {
132 double iterationDuration = iterationDurationValue->NumberValue();
133 setIterationDuration(result, iterationDuration); 132 setIterationDuration(result, iterationDuration);
134 } 133 }
135 134
136 double playbackRate = 1; 135 double playbackRate = 1;
137 timingInputDictionary.get("playbackRate", playbackRate); 136 timingInputDictionary.get("playbackRate", playbackRate);
138 setPlaybackRate(result, playbackRate); 137 setPlaybackRate(result, playbackRate);
139 138
140 String direction; 139 String direction;
141 timingInputDictionary.get("direction", direction); 140 timingInputDictionary.get("direction", direction);
142 setPlaybackDirection(result, direction); 141 setPlaybackDirection(result, direction);
143 142
144 String timingFunctionString; 143 String timingFunctionString;
145 timingInputDictionary.get("easing", timingFunctionString); 144 timingInputDictionary.get("easing", timingFunctionString);
146 setTimingFunction(result, timingFunctionString); 145 setTimingFunction(result, timingFunctionString);
147 146
148 result.assertValid(); 147 result.assertValid();
149 148
150 return result; 149 return result;
151 } 150 }
152 151
153 Timing TimingInput::convert(double duration) 152 Timing TimingInput::convert(double duration)
154 { 153 {
155 Timing result; 154 Timing result;
156 setIterationDuration(result, duration); 155 setIterationDuration(result, duration);
157 return result; 156 return result;
158 } 157 }
159 158
160 } // namespace WebCore 159 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698