Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1962423003: [gn] Refactoring - inverse libplatform config dependency (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Refactoring - inverse libplatform config dependency This makes sure that targets depending on v8_libplatform apply the required config. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/a78a32dc13d8c3222e657638e097dcfbffbc4d77 Cr-Commit-Position: refs/heads/master@{#36170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M BUILD.gn View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL
4 years, 7 months ago (2016-05-11 11:16:43 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-11 11:46:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962423003/1
4 years, 7 months ago (2016-05-11 11:57:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 12:03:24 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 12:04:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a78a32dc13d8c3222e657638e097dcfbffbc4d77
Cr-Commit-Position: refs/heads/master@{#36170}

Powered by Google App Engine
This is Rietveld 408576698