Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: BUILD.gn

Issue 1962423003: [gn] Refactoring - inverse libplatform config dependency (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 9727f2ffef5f5d308fc194d6086d7c99f36a9e21..3f6d9746d692b02c8544443fcdae0d00a61df322 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1960,6 +1960,10 @@ v8_source_set("v8_libplatform") {
":internal_config_base",
]
+ public_configs = [
+ ":libplatform_config"
+ ]
+
deps = [
":v8_libbase",
]
@@ -1975,13 +1979,15 @@ v8_source_set("fuzzer_support") {
configs = [
":internal_config_base",
- ":libplatform_config",
]
deps = [
- ":v8_libplatform",
snapshot_target,
]
+
+ public_deps = [
+ ":v8_libplatform",
+ ]
}
###############################################################################
@@ -2000,7 +2006,6 @@ if (current_toolchain == snapshot_toolchain) {
configs += [ "//build/config/compiler:no_chromium_code" ]
configs += [
":internal_config",
- ":libplatform_config",
":features",
":toolchain",
]
@@ -2141,7 +2146,6 @@ v8_source_set("json_fuzzer") {
configs = [
":internal_config",
- ":libplatform_config",
]
}
@@ -2156,7 +2160,6 @@ v8_source_set("parser_fuzzer") {
configs = [
":internal_config",
- ":libplatform_config",
]
}
@@ -2171,7 +2174,6 @@ v8_source_set("regexp_fuzzer") {
configs = [
":internal_config",
- ":libplatform_config",
]
}
@@ -2186,7 +2188,6 @@ v8_source_set("wasm_fuzzer") {
configs = [
":internal_config",
- ":libplatform_config",
]
}
@@ -2201,6 +2202,5 @@ v8_source_set("wasm_asmjs_fuzzer") {
configs = [
":internal_config",
- ":libplatform_config",
]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698