Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1962403004: Revert of Ship Node.rootNode (patchset #2 id:20001 of https://codereview.chromium.org/1783693002/ ) (Closed)

Created:
4 years, 7 months ago by kochi
Modified:
4 years, 7 months ago
Reviewers:
tkent, yuzuchan, hayato, kochi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Revert of Ship Node.rootNode (patchset #2 id:20001 of https://codereview.chromium.org/1783693002/ ) Reason for revert: Turns out that the change is not Web-compatible. See https://bugs.chromium.org/p/chromium/issues/detail?id=608006 for details. Original issue's description: > Ship Node.rootNode > > This CL ships Node.rootNode independently from other ShadowDOM features, in response to requests from web developers. > LGTM-ed on this thread : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LpXX7Svx8IY > > BUG=531990 > > Committed: https://crrev.com/9ca99ec409a1d6f7baf6dd3cd6929e81c967cac1 > Cr-Commit-Position: refs/heads/master@{#380363} TBR=tkent@chromium.org,hayato@chromium.org,kochi@chromium.org,yuzus@chromium.org BUG=531990, 608006 Review-Url: https://codereview.chromium.org/1945823004 Cr-Commit-Position: refs/heads/master@{#391723} (cherry picked from commit 08405679e3c56b833b4c6da3135b30485fad279b) Committed: https://chromium.googlesource.com/chromium/src/+/f0a505bf8131eb3bff547835f89dd3036ab5c90f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
kochi
Committed patchset #1 (id:1) manually as f0a505bf8131eb3bff547835f89dd3036ab5c90f.
4 years, 7 months ago (2016-05-11 01:35:04 UTC) #2
tkent
4 years, 7 months ago (2016-05-11 01:40:53 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698