Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Issue 1945823004: Revert of Ship Node.rootNode (Closed)

Created:
4 years, 7 months ago by dglazkov
Modified:
4 years, 7 months ago
Reviewers:
tkent, yuzuchan, hayato, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ship Node.rootNode (patchset #2 id:20001 of https://codereview.chromium.org/1783693002/ ) Reason for revert: Turns out that the change is not Web-compatible. See https://bugs.chromium.org/p/chromium/issues/detail?id=608006 for details. Original issue's description: > Ship Node.rootNode > > This CL ships Node.rootNode independently from other ShadowDOM features, in response to requests from web developers. > LGTM-ed on this thread : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LpXX7Svx8IY > > BUG=531990 > > Committed: https://crrev.com/9ca99ec409a1d6f7baf6dd3cd6929e81c967cac1 > Cr-Commit-Position: refs/heads/master@{#380363} TBR=tkent@chromium.org,hayato@chromium.org,kochi@chromium.org,yuzus@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=531990 Committed: https://crrev.com/08405679e3c56b833b4c6da3135b30485fad279b Cr-Commit-Position: refs/heads/master@{#391723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
dglazkov
Created Revert of Ship Node.rootNode
4 years, 7 months ago (2016-05-04 22:10:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945823004/1
4 years, 7 months ago (2016-05-04 22:10:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 01:18:16 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08405679e3c56b833b4c6da3135b30485fad279b Cr-Commit-Position: refs/heads/master@{#391723}
4 years, 7 months ago (2016-05-05 01:19:42 UTC) #5
kochi
lgtm
4 years, 7 months ago (2016-05-06 04:33:49 UTC) #6
hayato
4 years, 7 months ago (2016-05-09 04:59:13 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698