Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: blimp/client/session/blimp_client_session.h

Issue 1962393004: Added a debug info UI for Blimp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Kevin's comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/session/blimp_client_session.h
diff --git a/blimp/client/session/blimp_client_session.h b/blimp/client/session/blimp_client_session.h
index 71b4d3d0cf6b953ea465672811788d050b10311a..f8ccebea9770e08d413f7bbd3ee459413fee1181 100644
--- a/blimp/client/session/blimp_client_session.h
+++ b/blimp/client/session/blimp_client_session.h
@@ -5,6 +5,7 @@
#ifndef BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
#define BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
+#include <blimp/net/blimp_connection_statistics.h>
Kevin M 2016/05/20 01:02:03 Angle brackets are reserved for standard headers.
shaktisahu 2016/05/22 22:36:56 Done.
#include <memory>
#include <string>
@@ -70,11 +71,16 @@ class BlimpClientSession : public NetworkEventObserver {
RenderWidgetFeature* GetRenderWidgetFeature() const;
SettingsFeature* GetSettingsFeature() const;
+ BlimpConnectionStatistics* GetBlimpConnectionStatistics() const;
+
// The AssignmentCallback for when an assignment is ready. This will trigger
// a connection to the engine.
virtual void ConnectWithAssignment(AssignmentSource::Result result,
const Assignment& assignment);
+ void GetDebugInfo();
Kevin M 2016/05/20 01:02:03 Can we standardize the names here? DebugInfo or Co
+ virtual void UpdateDebugInfo(BlimpConnectionStatistics::StatisticsMap stats);
Kevin M 2016/05/20 01:02:03 Just take a const BlimpConnectionStatistics& ?
+
protected:
~BlimpClientSession() override;
@@ -101,6 +107,10 @@ class BlimpClientSession : public NetworkEventObserver {
// Connect() to get a valid assignment and later connect to the engine.
std::unique_ptr<AssignmentSource> assignment_source_;
+ // Collects details of network, such as number of commits and bytes
+ // transferred over network.
+ std::unique_ptr<BlimpConnectionStatistics> blimp_connection_statistics_;
+
// Container struct for network components.
// Must be deleted on the IO thread.
std::unique_ptr<ClientNetworkComponents> net_components_;

Powered by Google App Engine
This is Rietveld 408576698