Added a debug info UI for Blimp

blimp/client/session/blimp_client_session.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
 #define BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
 
+#include <blimp/net/blimp_connection_statistics.h>

[Kevin M, 2016/05/20 01:02:03]

Angle brackets are reserved for standard headers.

Put this in quotes, and move it to the block below.

[shaktisahu, 2016/05/22 22:36:56]

Done.

 #include <memory>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/threading/thread.h"
 #include "blimp/client/session/assignment_source.h"
 #include "blimp/common/proto/blimp_message.pb.h"
 #include "blimp/net/blimp_message_processor.h"
 
@@ skipping 45 matching lines @@
   // for an assignment.  This token needs the OAuth2 scope of userinfo.email and
   // only needs to be an access token, not a refresh token.
   void Connect(const std::string& client_auth_token);
 
   TabControlFeature* GetTabControlFeature() const;
   NavigationFeature* GetNavigationFeature() const;
   ImeFeature* GetImeFeature() const;
   RenderWidgetFeature* GetRenderWidgetFeature() const;
   SettingsFeature* GetSettingsFeature() const;
 
+  BlimpConnectionStatistics* GetBlimpConnectionStatistics() const;
+
   // The AssignmentCallback for when an assignment is ready. This will trigger
   // a connection to the engine.
   virtual void ConnectWithAssignment(AssignmentSource::Result result,
                                      const Assignment& assignment);
 
+  void GetDebugInfo();

[Kevin M, 2016/05/20 01:02:03]

Can we standardize the names here? DebugInfo or ConnectionStatistics, but not
both?

+  virtual void UpdateDebugInfo(BlimpConnectionStatistics::StatisticsMap stats);

[Kevin M, 2016/05/20 01:02:03]

Just take a const BlimpConnectionStatistics& ?

+
  protected:
   ~BlimpClientSession() override;
 
   // Notified every time the AssignmentSource returns the result of an attempted
   // assignment request.
   virtual void OnAssignmentConnectionAttempted(AssignmentSource::Result result,
                                                const Assignment& assignment);
 
  private:
   void RegisterFeatures();
 
   // NetworkEventObserver implementation.
   void OnConnected() override;
   void OnDisconnected(int result) override;
 
   base::Thread io_thread_;
   std::unique_ptr<TabControlFeature> tab_control_feature_;
   std::unique_ptr<NavigationFeature> navigation_feature_;
   std::unique_ptr<ImeFeature> ime_feature_;
   std::unique_ptr<RenderWidgetFeature> render_widget_feature_;
   std::unique_ptr<SettingsFeature> settings_feature_;
 
   // The AssignmentSource is used when the user of BlimpClientSession calls
   // Connect() to get a valid assignment and later connect to the engine.
   std::unique_ptr<AssignmentSource> assignment_source_;
 
+  // Collects details of network, such as number of commits and bytes
+  // transferred over network.
+  std::unique_ptr<BlimpConnectionStatistics> blimp_connection_statistics_;
+
   // Container struct for network components.
   // Must be deleted on the IO thread.
   std::unique_ptr<ClientNetworkComponents> net_components_;
 
   std::unique_ptr<ThreadPipeManager> thread_pipe_manager_;
 
   base::WeakPtrFactory<BlimpClientSession> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpClientSession);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_