chrome/browser/ui/views/translate/translate_icon_view.h - Issue 1962393003: log the click activate/deactive of translate icon on location bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_icon_view.h

Issue 1962393003: log the click activate/deactive of translate icon on location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/translate/translate_bubble_view.cc ('k') | chrome/browser/ui/views/translate/translate_icon_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/translate/translate_icon_view.h

diff --git a/chrome/browser/ui/views/translate/translate_icon_view.h b/chrome/browser/ui/views/translate/translate_icon_view.h

index b5c21f9e9f13143f29f6a5e96d7f233208c16f9f..ec4f57d04628b863bf6e886e4aa7c1350aae71ca 100644

--- a/chrome/browser/ui/views/translate/translate_icon_view.h

+++ b/chrome/browser/ui/views/translate/translate_icon_view.h

@@ -20,6 +20,7 @@ class TranslateIconView : public BubbleIconView {

protected:

// BubbleIconView:

void OnExecuting(BubbleIconView::ExecuteSource execute_source) override;

+ void OnPressed(bool activated) override;

views::BubbleDialogDelegateView* GetBubble() const override;

gfx::VectorIconId GetVectorIcon() const override;