chrome/browser/ui/views/translate/translate_bubble_view.cc - Issue 1962393003: log the click activate/deactive of translate icon on location bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 1962393003: log the click activate/deactive of translate icon on location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/bubble_icon_view.cc ('k') | chrome/browser/ui/views/translate/translate_icon_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/translate/translate_bubble_view.cc

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc

index 6b4dba941d56d103489d88e2e49abdd103dbe5a1..a3edc2cfcefe4573209bfd1a33b852277e1d7548 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc

+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc

@@ -51,8 +51,6 @@

namespace {

-const char kTranslateBubbleUIEvent[] = "Translate.BubbleUiEvent";

views::LabelButton* CreateBlueButton(views::ButtonListener* listener,

const base::string16& label,

int id) {

@@ -940,6 +938,6 @@ void TranslateBubbleView::UpdateAdvancedView() {

void TranslateBubbleView::ReportUiAction(

translate::TranslateBubbleUiEvent action) {

- UMA_HISTOGRAM_ENUMERATION(kTranslateBubbleUIEvent, action,

+ UMA_HISTOGRAM_ENUMERATION(translate::kTranslateBubbleUIEvent, action,

translate::TRANSLATE_BUBBLE_UI_EVENT_MAX);

}