Chromium Code Reviews| Index: chrome/browser/ui/views/location_bar/bubble_icon_view.h |
| diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.h b/chrome/browser/ui/views/location_bar/bubble_icon_view.h |
| index fb6f754d75f8686bd2c3bf1950c44944e33a06b9..d798a675e10380394b9faa7dbd1c447ad3a15b71 100644 |
| --- a/chrome/browser/ui/views/location_bar/bubble_icon_view.h |
| +++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.h |
| @@ -51,13 +51,16 @@ class BubbleIconView : public views::InkDropHostView, |
| // Sets the tooltip text. |
| void SetTooltipText(const base::string16& tooltip); |
| + // Invoked after the icon is clicked. |
|
msw
2016/05/11 18:51:35
nit: "icon is pressed."
ftang
2016/05/11 23:20:23
Done.
|
| + virtual void OnClicked(bool activated) {} |
|
msw
2016/05/11 18:51:35
nit: rename OnPressed to cover touch/keyboard invo
ftang
2016/05/11 23:20:23
Done.
|
| + |
| // Invoked prior to executing the command. |
| virtual void OnExecuting(ExecuteSource execute_source) = 0; |
| // views::View: |
| void GetAccessibleState(ui::AXViewState* state) override; |
| - bool GetTooltipText(const gfx::Point& p, base::string16* tooltip) const |
| - override; |
| + bool GetTooltipText(const gfx::Point& p, |
| + base::string16* tooltip) const override; |
| gfx::Size GetPreferredSize() const override; |
| void Layout() override; |
| bool OnMousePressed(const ui::MouseEvent& event) override; |
| @@ -77,8 +80,7 @@ class BubbleIconView : public views::InkDropHostView, |
| // views::WidgetObserver: |
| void OnWidgetDestroying(views::Widget* widget) override; |
| - void OnWidgetVisibilityChanged(views::Widget* widget, |
| - bool visible) override; |
| + void OnWidgetVisibilityChanged(views::Widget* widget, bool visible) override; |
| protected: |
| // Calls OnExecuting and runs |command_id_| with a valid |command_updater_|. |