chrome/browser/ui/translate/translate_bubble_view_state_transition.h - Issue 1962393003: log the click activate/deactive of translate icon on location bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/translate/translate_bubble_view_state_transition.h

Issue 1962393003: log the click activate/deactive of translate icon on location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed by 'git cl format --full' Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/translate/translate_bubble_view_state_transition.h

diff --git a/chrome/browser/ui/translate/translate_bubble_view_state_transition.h b/chrome/browser/ui/translate/translate_bubble_view_state_transition.h

index d99bcf7d26a6009b3bf8b32ce10010d2d63118ee..ae8139f16fa5c22a1e8116001d061f407a7e530a 100644

--- a/chrome/browser/ui/translate/translate_bubble_view_state_transition.h

+++ b/chrome/browser/ui/translate/translate_bubble_view_state_transition.h

@@ -62,6 +62,12 @@ enum TranslateBubbleUiEvent {

// The user changed the "Target language".

TARGET_LANGUAGE_MENU_CLICKED,

+ // The user click to activate the Omnibar Translate icon.

msw 2016/05/11 18:51:35 'Omnibar' is not the correct colloquial term; say

ftang 2016/05/11 23:20:23 Done.

+ OMNIBAR_ICON_CLICK_ACTIVATE,

+ // The user click to deactivate the Omnibar Translate icon.

+ OMNIBAR_ICON_CLICK_DEACTIVATE,

TRANSLATE_BUBBLE_UI_EVENT_MAX

};

« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/bubble_icon_view.h » ('j') | chrome/browser/ui/views/location_bar/bubble_icon_view.h » ('J')