components/test_runner/web_test_proxy.h - Issue 1962393002: Destroy WebWidgetTestClient when its WebWidget is destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_test_proxy.h

Issue 1962393002: Destroy WebWidgetTestClient when its WebWidget is destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/shell/renderer/layout_test/layout_test_render_frame_observer.h » ('j') | content/shell/renderer/layout_test/layout_test_render_frame_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/web_test_proxy.h

diff --git a/components/test_runner/web_test_proxy.h b/components/test_runner/web_test_proxy.h

index b23e69313bd675ca23c29a9f727864f68eab501a..ff5fe50aba189401c08eabff0d75f607fc7c93d6 100644

--- a/components/test_runner/web_test_proxy.h

+++ b/components/test_runner/web_test_proxy.h

@@ -59,8 +59,6 @@ class TEST_RUNNER_EXPORT WebTestProxyBase {

public:

blink::WebWidget* web_widget() { return web_widget_; }

void set_web_widget(blink::WebWidget* widget) {

- DCHECK(widget);

- DCHECK(!web_widget_);

web_widget_ = widget;

}

@@ -80,8 +78,6 @@ class TEST_RUNNER_EXPORT WebTestProxyBase {

void set_widget_test_client(

std::unique_ptr<WebWidgetTestClient> widget_test_client) {

- DCHECK(widget_test_client);

- DCHECK(!widget_test_client_);

Łukasz Anforowicz 2016/05/10 19:44:40 This doesn't seem right - WebTestProxy dereference

widget_test_client_ = std::move(widget_test_client);

}