content/shell/renderer/layout_test/layout_test_render_frame_observer.h - Issue 1962393002: Destroy WebWidgetTestClient when its WebWidget is destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.h

Issue 1962393002: Destroy WebWidgetTestClient when its WebWidget is destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/web_test_proxy.h ('K') | « components/test_runner/web_test_proxy.h ('k') | content/shell/renderer/layout_test/layout_test_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.h

diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.h b/content/shell/renderer/layout_test/layout_test_render_frame_observer.h

index 3f5da4ae1064b34d1b956940fd2ce2115e83054a..277a6f49bbaef2d6d7e83b0c49969df65f2d1565 100644

--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.h

+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.h

@@ -27,6 +27,7 @@ class LayoutTestRenderFrameObserver : public RenderFrameObserver {

~LayoutTestRenderFrameObserver() override {}

bool OnMessageReceived(const IPC::Message& message) override;

+ void FrameDetached() override;

Łukasz Anforowicz 2016/05/10 19:44:40 I wonder if this notification could be handled ent

private:

void OnLayoutDumpRequest();