ui/views/controls/menu/menu_host.cc - Issue 196213004: Allows menu host windows to be enumerated in DragTargetWindowFinder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_host.cc

Issue 196213004: Allows menu host windows to be enumerated in DragTargetWindowFinder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implements menu XID caching and dispatches mouse drags in a posted task (test) Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/base/x/x11_util.cc ('K') | « ui/base/x/x11_util.cc ('k') | ui/views/corewm/desktop_capture_controller_unittest.cc » ('j') | ui/views/corewm/desktop_capture_controller_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/menu/menu_host.cc

diff --git a/ui/views/controls/menu/menu_host.cc b/ui/views/controls/menu/menu_host.cc

index 5e8593b98ab06b57bc2e780541d1fe18b8f904b4..e79267193e452dd9d6ea9080109a02be5711c420 100644

--- a/ui/views/controls/menu/menu_host.cc

+++ b/ui/views/controls/menu/menu_host.cc

@@ -92,6 +92,10 @@ void MenuHost::DestroyMenuHost() {

destroying_ = true;

static_cast<MenuHostRootView*>(GetRootView())->ClearSubmenu();

Close();

+ // Since |submenu_| is not a child view it is necessary to notify its

+ // observers so that they can clean up the foucs and drag and drop state.

+ View::ViewHierarchyChangedDetails details(false, NULL, submenu_, NULL);

+ ViewHierarchyChanged(details);

sadrul 2014/03/26 18:01:07 Can this be separated out in a different CL with c

varkha 2014/03/27 04:48:13 See https://codereview.chromium.org/214083004/.

}

void MenuHost::SetMenuHostBounds(const gfx::Rect& bounds) {

« ui/base/x/x11_util.cc ('K') | « ui/base/x/x11_util.cc ('k') | ui/views/corewm/desktop_capture_controller_unittest.cc » ('j') | ui/views/corewm/desktop_capture_controller_unittest.cc » ('J')