Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: ui/views/corewm/desktop_capture_controller_unittest.cc

Issue 196213004: Allows menu host windows to be enumerated in DragTargetWindowFinder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implements menu XID caching and dispatches mouse drags in a posted task (test) Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/corewm/desktop_capture_controller_unittest.cc
diff --git a/ui/views/corewm/desktop_capture_controller_unittest.cc b/ui/views/corewm/desktop_capture_controller_unittest.cc
index ad6d849e03ebb985bf39d3aca62f34bf698e441f..8807aafdd6eb322ffccc1993fd2ae12f860e2417 100644
--- a/ui/views/corewm/desktop_capture_controller_unittest.cc
+++ b/ui/views/corewm/desktop_capture_controller_unittest.cc
@@ -101,6 +101,7 @@ TEST_F(DesktopCaptureControllerTest, ResetMouseHandlers) {
EXPECT_TRUE(w1_dispatcher->mouse_pressed_handler() == NULL);
EXPECT_TRUE(w1_dispatcher->mouse_moved_handler() == NULL);
w2->ReleaseCapture();
+ RunPendingMessages();
varkha 2014/03/26 00:15:53 This test was failing because all the windows were
sadrul 2014/03/26 18:01:07 I believe some tests run this in the TearDown() ov
varkha 2014/03/27 04:48:13 The problem is that w1/w2 get destroyed when exiti
sadrul 2014/03/27 19:13:46 I see. That sounds like a bug. It would be a good
varkha 2014/03/27 20:05:29 We discussed this offline a bit. If we do not call
}
// Tests aura::Window capture and whether gesture events are sent to the window

Powered by Google App Engine
This is Rietveld 408576698