Allow expensive task blocking if there is pending iframe navigation

Allow expensive task blocking if there is pending iframe navigation

The motivation for this patch is to gain the benefits of the expensive
task blocking intervention even if an iframe is navigating.  This
should help improve touch responsiveness on ad heavy pages.

We still prevent expensive task blocking when there is a pending main
frame navigation.

BUG=600202
Committed: https://crrev.com/bb4be51059b55cd04c329d2d296ebcc7e808b215
Cr-Commit-Position: refs/heads/master@{#392583}

[alex clarke (OOO till 29th), 2016-05-09 16:17:34]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 16:17:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1962053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1962053002/1

[alex clarke (OOO till 29th), 2016-05-09 16:18:35]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2016-05-09 16:45:21]

https://codereview.chromium.org/1962053002/diff/1/components/scheduler/child/...
File components/scheduler/child/web_scheduler_impl.h (right):

https://codereview.chromium.org/1962053002/diff/1/components/scheduler/child/...
components/scheduler/child/web_scheduler_impl.h:47: void
addPendingNavigation(bool main_frame_navigating) override {}
camelCase at this layer :P

https://codereview.chromium.org/1962053002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebScheduler.h (right):

https://codereview.chromium.org/1962053002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebScheduler.h:84: virtual void
addPendingNavigation(bool mainFrameNavigating) = 0;
I'm tempted to suggest making this an enum instead for readability. WDYT?

[alex clarke (OOO till 29th), 2016-05-09 17:08:09]

https://codereview.chromium.org/1962053002/diff/1/components/scheduler/child/...
File components/scheduler/child/web_scheduler_impl.h (right):

https://codereview.chromium.org/1962053002/diff/1/components/scheduler/child/...
components/scheduler/child/web_scheduler_impl.h:47: void
addPendingNavigation(bool main_frame_navigating) override {}
On 2016/05/09 16:45:21, Sami wrote:
> camelCase at this layer :P

I made the name shorter ;)

https://codereview.chromium.org/1962053002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebScheduler.h (right):

https://codereview.chromium.org/1962053002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebScheduler.h:84: virtual void
addPendingNavigation(bool mainFrameNavigating) = 0;
On 2016/05/09 16:45:21, Sami wrote:
> I'm tempted to suggest making this an enum instead for readability. WDYT?

Yeah I was tempted to do that too, but didn't initially.  It's done now.

[alex clarke (OOO till 29th), 2016-05-09 17:08:15]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 17:08:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1962053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1962053002/20001

[Sami, 2016-05-09 17:49:50]

Description was changed from

==========
Allow expensive task blocking if there is pending iframe navigation

The motivation for this patch is to gain the benefits of the expensive
task blocking intervention even if an iframe is navigating.  This
should help improve touch responsiveness on ad heavy pages.

We still prevent expensive task blocking when there is a pending main
frame navigation.

BUG=600202
==========

to

==========
Allow expensive task blocking if there is pending iframe navigation

The motivation for this patch is to gain the benefits of the expensive
task blocking intervention even if an iframe is navigating.  This
should help improve touch responsiveness on ad heavy pages.

We still prevent expensive task blocking when there is a pending main
frame navigation.

BUG=600202
==========

[Sami, 2016-05-09 17:49:50]

skyostil@chromium.org changed reviewers:
+ jochen@chromium.org

[Sami, 2016-05-09 17:50:01]

lgtm

[commit-bot: I haz the power, 2016-05-09 18:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 18:15:24]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-05-10 11:53:11]

lgtm

[alex clarke (OOO till 29th), 2016-05-10 12:13:05]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2016-05-10 12:13:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1962053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1962053002/20001

[commit-bot: I haz the power, 2016-05-10 12:16:49]

Description was changed from

==========
Allow expensive task blocking if there is pending iframe navigation

The motivation for this patch is to gain the benefits of the expensive
task blocking intervention even if an iframe is navigating.  This
should help improve touch responsiveness on ad heavy pages.

We still prevent expensive task blocking when there is a pending main
frame navigation.

BUG=600202
==========

to

==========
Allow expensive task blocking if there is pending iframe navigation

The motivation for this patch is to gain the benefits of the expensive
task blocking intervention even if an iframe is navigating.  This
should help improve touch responsiveness on ad heavy pages.

We still prevent expensive task blocking when there is a pending main
frame navigation.

BUG=600202
==========

[commit-bot: I haz the power, 2016-05-10 12:16:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 12:18:08]

Description was changed from

==========
Allow expensive task blocking if there is pending iframe navigation

The motivation for this patch is to gain the benefits of the expensive
task blocking intervention even if an iframe is navigating.  This
should help improve touch responsiveness on ad heavy pages.

We still prevent expensive task blocking when there is a pending main
frame navigation.

BUG=600202
==========

to

==========
Allow expensive task blocking if there is pending iframe navigation

The motivation for this patch is to gain the benefits of the expensive
task blocking intervention even if an iframe is navigating.  This
should help improve touch responsiveness on ad heavy pages.

We still prevent expensive task blocking when there is a pending main
frame navigation.

BUG=600202

Committed: https://crrev.com/bb4be51059b55cd04c329d2d296ebcc7e808b215
Cr-Commit-Position: refs/heads/master@{#392583}
==========

[commit-bot: I haz the power, 2016-05-10 12:18:09]

Patchset 2 (id:??) landed as
https://crrev.com/bb4be51059b55cd04c329d2d296ebcc7e808b215
Cr-Commit-Position: refs/heads/master@{#392583}