Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.cc

Issue 1962053002: Allow expensive task blocking if there is pending iframe navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use an enum Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/components/scheduler/renderer/renderer_scheduler_impl.cc b/components/scheduler/renderer/renderer_scheduler_impl.cc
index 3ae7991381cf6b59f152c4dbce6d4b3b2a3a95e5..571b0912506900b0d2098a645ff50ee45bb88cf3 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl.cc
@@ -1128,18 +1128,24 @@ void RendererSchedulerImpl::OnIdlePeriodEnded() {
UpdatePolicyLocked(UpdateType::MAY_EARLY_OUT_IF_POLICY_UNCHANGED);
}
-void RendererSchedulerImpl::AddPendingNavigation() {
+void RendererSchedulerImpl::AddPendingNavigation(
+ blink::WebScheduler::NavigatingFrameType type) {
helper_.CheckOnValidThread();
- MainThreadOnly().navigation_task_expected_count++;
- UpdatePolicy();
+ if (type == blink::WebScheduler::NavigatingFrameType::kMainFrame) {
+ MainThreadOnly().navigation_task_expected_count++;
+ UpdatePolicy();
+ }
}
-void RendererSchedulerImpl::RemovePendingNavigation() {
+void RendererSchedulerImpl::RemovePendingNavigation(
+ blink::WebScheduler::NavigatingFrameType type) {
helper_.CheckOnValidThread();
DCHECK_GT(MainThreadOnly().navigation_task_expected_count, 0);
- if (MainThreadOnly().navigation_task_expected_count > 0)
+ if (type == blink::WebScheduler::NavigatingFrameType::kMainFrame &&
+ MainThreadOnly().navigation_task_expected_count > 0) {
MainThreadOnly().navigation_task_expected_count--;
- UpdatePolicy();
+ UpdatePolicy();
+ }
}
void RendererSchedulerImpl::OnNavigationStarted() {

Powered by Google App Engine
This is Rietveld 408576698