Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1962043002: Move Show and Hide impls from PlatformWindowMus to NativeWidgetMus (Closed)

Created:
4 years, 7 months ago by Mark Dittmer
Modified:
4 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Show and Hide impls from PlatformWindowMus to NativeWidgetMus R=sadrul@chromium.org BUG=609555 Committed: https://crrev.com/1462909717a364b71c6291e742b2fc763b69b849 Cr-Commit-Position: refs/heads/master@{#392615}

Patch Set 1 #

Total comments: 2

Patch Set 2 : DO NOT COMMIT: Test code checks for unexpected Show/Hide calls #

Patch Set 3 : Drop WIP testing code #

Patch Set 4 : rebase #

Patch Set 5 : Drop use of NOTIMPLEMENTED #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M ui/views/mus/native_widget_mus.cc View 1 2 3 4 5 3 chunks +6 lines, -2 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 2 3 4 5 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962043002/1
4 years, 7 months ago (2016-05-09 15:50:05 UTC) #2
Mark Dittmer
DO NOT COMMIT: Test code checks for unexpected Show/Hide calls
4 years, 7 months ago (2016-05-09 16:01:37 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962043002/20001
4 years, 7 months ago (2016-05-09 16:02:05 UTC) #5
Mark Dittmer
On 2016/05/09 16:01:37, Mark Dittmer wrote: > DO NOT COMMIT: Test code checks for unexpected ...
4 years, 7 months ago (2016-05-09 16:02:10 UTC) #6
sadrul
https://codereview.chromium.org/1962043002/diff/1/ui/views/mus/platform_window_mus.cc File ui/views/mus/platform_window_mus.cc (right): https://codereview.chromium.org/1962043002/diff/1/ui/views/mus/platform_window_mus.cc#newcode132 ui/views/mus/platform_window_mus.cc:132: NOTIMPLEMENTED(); Add a class-level comment that PlatformWindowMus is going ...
4 years, 7 months ago (2016-05-09 16:38:26 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/18603)
4 years, 7 months ago (2016-05-09 17:23:22 UTC) #9
Mark Dittmer
Drop WIP testing code
4 years, 7 months ago (2016-05-09 17:53:10 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962043002/40001
4 years, 7 months ago (2016-05-09 17:54:16 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 18:34:18 UTC) #14
Mark Dittmer
rebase
4 years, 7 months ago (2016-05-09 19:03:57 UTC) #15
Mark Dittmer
All comments addressed. https://codereview.chromium.org/1962043002/diff/1/ui/views/mus/platform_window_mus.cc File ui/views/mus/platform_window_mus.cc (right): https://codereview.chromium.org/1962043002/diff/1/ui/views/mus/platform_window_mus.cc#newcode132 ui/views/mus/platform_window_mus.cc:132: NOTIMPLEMENTED(); On 2016/05/09 16:38:26, sadrul wrote: ...
4 years, 7 months ago (2016-05-09 19:04:44 UTC) #16
sadrul
lgtm
4 years, 7 months ago (2016-05-09 20:20:48 UTC) #17
Mark Dittmer
Drop use of NOTIMPLEMENTED
4 years, 7 months ago (2016-05-10 13:31:23 UTC) #18
Mark Dittmer
rebase
4 years, 7 months ago (2016-05-10 14:31:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962043002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962043002/100001
4 years, 7 months ago (2016-05-10 14:32:12 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-10 15:32:01 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 15:33:10 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/1462909717a364b71c6291e742b2fc763b69b849
Cr-Commit-Position: refs/heads/master@{#392615}

Powered by Google App Engine
This is Rietveld 408576698