Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Side by Side Diff: ui/views/mus/platform_window_mus.cc

Issue 1962043002: Move Show and Hide impls from PlatformWindowMus to NativeWidgetMus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/mus/native_widget_mus.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/mus/platform_window_mus.h" 5 #include "ui/views/mus/platform_window_mus.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "components/bitmap_uploader/bitmap_uploader.h" 9 #include "components/bitmap_uploader/bitmap_uploader.h"
10 #include "components/mus/public/cpp/property_type_converters.h" 10 #include "components/mus/public/cpp/property_type_converters.h"
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 if (last_cursor_ != cursor) { 109 if (last_cursor_ != cursor) {
110 // The ui::PlatformWindow interface uses ui::PlatformCursor at this level, 110 // The ui::PlatformWindow interface uses ui::PlatformCursor at this level,
111 // instead of ui::Cursor. All of the cursor abstractions in ui right now are 111 // instead of ui::Cursor. All of the cursor abstractions in ui right now are
112 // sort of leaky; despite being nominally cross platform, they all drop down 112 // sort of leaky; despite being nominally cross platform, they all drop down
113 // to platform types almost immediately, which makes them unusable as 113 // to platform types almost immediately, which makes them unusable as
114 // transport types. 114 // transport types.
115 mus_window_->SetPredefinedCursor(cursor); 115 mus_window_->SetPredefinedCursor(cursor);
116 } 116 }
117 } 117 }
118 118
119 void PlatformWindowMus::Show() { 119 void PlatformWindowMus::Show() {}
120 mus_window_->SetVisible(true);
121 }
122 120
123 void PlatformWindowMus::Hide() { 121 void PlatformWindowMus::Hide() {}
124 mus_window_->SetVisible(false);
125 }
126 122
127 void PlatformWindowMus::Close() { 123 void PlatformWindowMus::Close() {
128 NOTIMPLEMENTED(); 124 NOTIMPLEMENTED();
129 } 125 }
130 126
131 void PlatformWindowMus::SetBounds(const gfx::Rect& bounds) {} 127 void PlatformWindowMus::SetBounds(const gfx::Rect& bounds) {}
132 128
133 gfx::Rect PlatformWindowMus::GetBounds() { 129 gfx::Rect PlatformWindowMus::GetBounds() {
134 return mus_window_->bounds(); 130 return mus_window_->bounds();
135 } 131 }
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 257
262 std::unique_ptr<ui::Event> event = ui::Event::Clone(event_in); 258 std::unique_ptr<ui::Event> event = ui::Event::Clone(event_in);
263 delegate_->DispatchEvent(event.get()); 259 delegate_->DispatchEvent(event.get());
264 // NOTE: |this| may be deleted. 260 // NOTE: |this| may be deleted.
265 261
266 ack_handler.set_handled(event->handled()); 262 ack_handler.set_handled(event->handled());
267 // |ack_handler| acks the event on destruction if necessary. 263 // |ack_handler| acks the event on destruction if necessary.
268 } 264 }
269 265
270 } // namespace views 266 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/mus/native_widget_mus.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698