Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1961953002: Reland of Simplify SkGpuBlurUtils::GaussianBlur method (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of Simplify SkGpuBlurUtils::GaussianBlur method (patchset #1 id:1 of https://codereview.chromium.org/1956023002/ ) Reason for revert: May not be as bad as was thought Original issue's description: > Revert of Simplify SkGpuBlurUtils::GaussianBlur method (patchset #2 id:20001 of https://codereview.chromium.org/1958603002/ ) > > Reason for revert: > Looks like it's causing some issues with the bleed_image GM. > > Original issue's description: > > Simplify SkGpuBlurUtils::GaussianBlur method > > > > No one was using the canClobberSrc capability and moving the direct filtering case forward makes the rest of the logic simpler. > > > > Split out of: https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) > > > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1958603002 > > > > Committed: https://skia.googlesource.com/skia/+/56a85e69a8d034e0fdee00e8207cda0a9da06fee > > TBR=bsalomon@google.com,robertphillips@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/67a58dcd4a1e79e5832161ae953526d27893aa61 TBR=bsalomon@google.com,jvanverth@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://skia.googlesource.com/skia/+/a8966a8a34f32bf3bb1dd2f9b6a77cdb1ebe1809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -110 lines) Patch
M include/gpu/GrContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 5 chunks +101 lines, -102 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
robertphillips
Created Reland of Simplify SkGpuBlurUtils::GaussianBlur method
4 years, 7 months ago (2016-05-09 13:24:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961953002/1
4 years, 7 months ago (2016-05-09 13:24:26 UTC) #2
bsalomon
lgtm
4 years, 7 months ago (2016-05-09 13:27:14 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 13:45:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a8966a8a34f32bf3bb1dd2f9b6a77cdb1ebe1809

Powered by Google App Engine
This is Rietveld 408576698