Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 196193003: Revert "Simplify SVGSVGElement::getElementById method" (Closed)

Created:
6 years, 9 months ago by maheshkk
Modified:
6 years, 9 months ago
Reviewers:
pdr., Inactive, rwlbuis
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert "Simplify SVGSVGElement::getElementById method" This reverts commit 54c88454a2f94147690450bc9b499361044c8ba3. Reverting this fix because it assumed when SVG.getElementById is called the element is already part of the document and did not search svg subtree when the element is not found using above api. Add test when svg element is not part of any document, it should still be able to getElementById for it's child elements. BUG=351831 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169157

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M LayoutTests/svg/custom/svg-getelementid.xhtml View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/svg-getelementid-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +11 lines, -13 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
maheshkk
PTAL
6 years, 9 months ago (2014-03-13 17:09:10 UTC) #1
Inactive
On 2014/03/13 17:09:10, maheshkk wrote: > PTAL Please explain in the changelog the reason why ...
6 years, 9 months ago (2014-03-13 17:12:33 UTC) #2
maheshkk
On 2014/03/13 17:12:33, Chris Dumez wrote: > On 2014/03/13 17:09:10, maheshkk wrote: > > PTAL ...
6 years, 9 months ago (2014-03-13 18:02:20 UTC) #3
Inactive
lgtm https://codereview.chromium.org/196193003/diff/1/Source/core/svg/SVGSVGElement.cpp File Source/core/svg/SVGSVGElement.cpp (right): https://codereview.chromium.org/196193003/diff/1/Source/core/svg/SVGSVGElement.cpp#newcode828 Source/core/svg/SVGSVGElement.cpp:828: for (Node* node = firstChild(); node; node = ...
6 years, 9 months ago (2014-03-13 18:11:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/196193003/1
6 years, 9 months ago (2014-03-13 18:11:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 19:03:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_blink_rel
6 years, 9 months ago (2014-03-13 19:03:33 UTC) #7
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 9 months ago (2014-03-13 19:09:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/196193003/1
6 years, 9 months ago (2014-03-13 19:10:08 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 22:02:57 UTC) #10
Message was sent while issue was closed.
Change committed as 169157

Powered by Google App Engine
This is Rietveld 408576698