LayoutTests/svg/custom/svg-getelementid.xhtml - Issue 196193003: Revert "Simplify SVGSVGElement::getElementById method"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/custom/svg-getelementid.xhtml

Issue 196193003: Revert "Simplify SVGSVGElement::getElementById method" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/svg/custom/svg-getelementid.xhtml

diff --git a/LayoutTests/svg/custom/svg-getelementid.xhtml b/LayoutTests/svg/custom/svg-getelementid.xhtml

index f7e7c69ff6e524862052315369573688ba7f50dd..ded5cd2b3d2998a0c442eff13420fc43cb4729d7 100644

--- a/LayoutTests/svg/custom/svg-getelementid.xhtml

+++ b/LayoutTests/svg/custom/svg-getelementid.xhtml

@@ -79,6 +79,13 @@

var nonsvg = root.getElementById("nonsvg");

var foreign = root.getElementById("foreign");

shouldBeTrue("foreign.firstChild.nextSibling == nonsvg");

+ // Test that SVG element can find child elements when svg is not part of document yet

+ var orphanSvg = document.createElementNS('http://www.w3.org/2000/svg', 'svg');

+ var childSvg = document.createElementNS('http://www.w3.org/2000/svg', 'g');

+ orphanSvg.appendChild(childSvg)

+ childSvg.id = 'fooSvg2'

+ shouldBeTrue("childSvg == orphanSvg.getElementById('fooSvg2')");

]]></script>

</body>

« no previous file with comments | « no previous file | LayoutTests/svg/custom/svg-getelementid-expected.txt » ('j') | Source/core/svg/SVGSVGElement.cpp » ('J')