Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1961893002: Instrument callers of Semaphore::Signal to help with investigation of (Closed)

Created:
4 years, 7 months ago by ulan
Modified:
4 years, 7 months ago
Reviewers:
Michael Lippautz, Yang
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Instrument callers of Semaphore::Signal to help with investigation of flaky crashes. BUG=chromium:609249 LOG=NO Committed: https://crrev.com/5d9f6da6541c24077f236fe9a1837e0e8261a3ea Cr-Commit-Position: refs/heads/master@{#36106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/base/platform/semaphore.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/semaphore.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/page-parallel-job.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/log.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
ulan
ptal
4 years, 7 months ago (2016-05-09 10:54:30 UTC) #2
Yang
src/debug lgtm.
4 years, 7 months ago (2016-05-09 10:55:34 UTC) #4
Michael Lippautz
lgtm
4 years, 7 months ago (2016-05-09 11:11:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961893002/1
4 years, 7 months ago (2016-05-09 11:26:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 11:55:22 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 11:55:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d9f6da6541c24077f236fe9a1837e0e8261a3ea
Cr-Commit-Position: refs/heads/master@{#36106}

Powered by Google App Engine
This is Rietveld 408576698