Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 1961743002: Subzero: Update for LLVM 3.9 (trunk). (Closed)

Created:
4 years, 7 months ago by Jim Stichnoth
Modified:
4 years, 7 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Update for LLVM 3.9 (trunk). The purpose is to allow pnacl-sz to be built within an LLVM checkout (version 3.9 or later), and not require the complex PNaCl build environment. Within an LLVM checkout, one would do something like the following: cd projects git clone https://chromium.googlesource.com/native_client/pnacl-subzero # change to LLVM build directory cmake -G "Ninja" <path_to_llvm_source_dir> ninja A follow-on CL will add in the PNaCl bitcode reader source files that are needed for compiling and linking. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f5fdd2360751122d30280173e0d6c9a3ecf2f72e

Patch Set 1 #

Patch Set 2 : make format #

Patch Set 3 : Remove unnecessary variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -23 lines) Patch
M CMakeLists.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M Makefile View 1 chunk +2 lines, -0 lines 0 comments Download
M Makefile.standalone View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceBitVector.h View 1 3 chunks +10 lines, -2 lines 0 comments Download
M src/IceCfg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceCfgNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceClFlags.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/IceClFlags.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M src/IceCompileServer.cpp View 1 3 chunks +12 lines, -4 lines 0 comments Download
M src/IceCompiler.cpp View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M src/IceConverter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/IceInst.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/IceTargetLowering.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLowering.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/SZTargets.def View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 7 months ago (2016-05-08 16:31:12 UTC) #3
John
lgtm
4 years, 7 months ago (2016-05-09 19:07:55 UTC) #4
Jim Stichnoth
4 years, 7 months ago (2016-05-09 19:24:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f5fdd2360751122d30280173e0d6c9a3ecf2f72e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698