base: Make SequenceChecker death tests multi-threads work correctly.

base: Make SequenceChecker death tests multi-threads work correctly.

TBR=akalin,darin

BUG=261141
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212725

[tommycli, 2013-07-19 15:49:24]

rnk: I think this fixes the SequenceChecker death tests by disabling the
multi-threaded execution of these tests.

I'm having trouble testing this though, as the failure only seems to appear on
Mac's valgrind. Should we just send this through the CQ?

[Reid Kleckner, 2013-07-19 16:23:00]

LGTM if the gtest flags get reset.

https://codereview.chromium.org/19617002/diff/7001/base/sequence_checker_unit...
File base/sequence_checker_unittest.cc (right):

https://codereview.chromium.org/19617002/diff/7001/base/sequence_checker_unit...
base/sequence_checker_unittest.cc:200: ::testing::FLAGS_gtest_death_test_style =
"threadsafe";
Do these get reset after each test?

[Reid Kleckner, 2013-07-19 16:24:30]

I wonder if there's some kind of RAII style value saver/restorer that you could
put on the fixture to make this safer.

[tommycli, 2013-07-19 16:59:28]

On 2013/07/19 16:24:30, Reid Kleckner wrote:
> I wonder if there's some kind of RAII style value saver/restorer that you
could
> put on the fixture to make this safer.

Flags automatically restored per test:
https://code.google.com/p/googletest/wiki/AdvancedGuide.

No guarantee that this will actually fix it, but this is what other multi-thread
death tests do, so I'd say a good chance it will. Let's give it a shot.

[tommycli, 2013-07-19 16:59:57]

https://codereview.chromium.org/19617002/diff/7001/base/sequence_checker_unit...
File base/sequence_checker_unittest.cc (right):

https://codereview.chromium.org/19617002/diff/7001/base/sequence_checker_unit...
base/sequence_checker_unittest.cc:200: ::testing::FLAGS_gtest_death_test_style =
"threadsafe";
On 2013/07/19 16:23:00, Reid Kleckner wrote:
> Do these get reset after each test?

Yes, reset after each test.

[commit-bot: I haz the power, 2013-07-19 17:00:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommycli@chromium.org/19617002/7001

[commit-bot: I haz the power, 2013-07-19 17:12:43]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-07-19 17:14:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommycli@chromium.org/19617002/7001

[commit-bot: I haz the power, 2013-07-19 17:55:58]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Timur Iskhodzhanov, 2013-07-19 19:22:07]

https://codereview.chromium.org/19617002/diff/7001/base/sequence_checker_unit...
File base/sequence_checker_unittest.cc (right):

https://codereview.chromium.org/19617002/diff/7001/base/sequence_checker_unit...
base/sequence_checker_unittest.cc:200: ::testing::FLAGS_gtest_death_test_style =
"threadsafe";
Why not put it into the fixture?

[tommycli, 2013-07-19 19:30:53]

https://codereview.chromium.org/19617002/diff/7001/base/sequence_checker_unit...
File base/sequence_checker_unittest.cc (right):

https://codereview.chromium.org/19617002/diff/7001/base/sequence_checker_unit...
base/sequence_checker_unittest.cc:200: ::testing::FLAGS_gtest_death_test_style =
"threadsafe";
On 2013/07/19 19:22:07, Timur Iskhodzhanov wrote:
> Why not put it into the fixture?

No technical reason why it can't be in fixture. Just that all other death tests
that use this flag declare in body, not in fixture.

[commit-bot: I haz the power, 2013-07-19 19:34:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommycli@chromium.org/19617002/7001

[commit-bot: I haz the power, 2013-07-20 02:48:38]

Change committed as 212725