base: Make SequenceChecker death tests multi-threads work correctly.

base/sequence_checker_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
@@ skipping 178 matching lines @@
       new SequenceCheckedObject);
 
   // DoStuff should assert in debug builds only when called on a
   // different thread.
   PostDoStuffToOtherThread(sequence_checked_object.get());
   other_thread()->Stop();
 }
 
 #if ENABLE_SEQUENCE_CHECKER
 TEST_F(SequenceCheckerTest, MethodNotAllowedOnDifferentThreadDeathTestInDebug) {
+  // The default style "fast" does not support multi-threaded tests.
+  ::testing::FLAGS_gtest_death_test_style = "threadsafe";

[Reid Kleckner, 2013/07/19 16:23:00]

Do these get reset after each test?

[tommycli, 2013/07/19 16:59:57]

Yes, reset after each test.

[Timur Iskhodzhanov, 2013/07/19 19:22:07]

Why not put it into the fixture?

[tommycli, 2013/07/19 19:30:53]

No technical reason why it can't be in fixture. Just that all other death tests
that use this flag declare in body, not in fixture.

   ASSERT_DEATH({
     MethodOnDifferentThreadDeathTest();
   }, "");
 }
 #else
 TEST_F(SequenceCheckerTest, MethodAllowedOnDifferentThreadDeathTestInRelease) {
   MethodOnDifferentThreadDeathTest();
 }
 #endif  // ENABLE_SEQUENCE_CHECKER
 
 void SequenceCheckerTest::DetachThenCallFromDifferentThreadDeathTest() {
   scoped_ptr<SequenceCheckedObject> sequence_checked_object(
       new SequenceCheckedObject);
 
   // DoStuff doesn't assert when called on a different thread
   // after a call to DetachFromSequence.
   sequence_checked_object->DetachFromSequence();
   PostDoStuffToOtherThread(sequence_checked_object.get());
   other_thread()->Stop();
 
   // DoStuff should assert in debug builds only after moving to
   // another thread.
   sequence_checked_object->DoStuff();
 }
 
 #if ENABLE_SEQUENCE_CHECKER
 TEST_F(SequenceCheckerTest, DetachFromSequenceDeathTestInDebug) {
+  // The default style "fast" does not support multi-threaded tests.
+  ::testing::FLAGS_gtest_death_test_style = "threadsafe";
   ASSERT_DEATH({
     DetachThenCallFromDifferentThreadDeathTest();
   }, "");
 }
 #else
 TEST_F(SequenceCheckerTest, DetachFromThreadDeathTestInRelease) {
   DetachThenCallFromDifferentThreadDeathTest();
 }
 #endif  // ENABLE_SEQUENCE_CHECKER
 
 void SequenceCheckerTest::DifferentSequenceTokensDeathTest() {
   scoped_ptr<SequenceCheckedObject> sequence_checked_object(
       new SequenceCheckedObject);
 
   sequence_checked_object->DetachFromSequence();
   PostDoStuffToWorkerPool(sequence_checked_object.get(), "A");
   PostDoStuffToWorkerPool(sequence_checked_object.get(), "A");
   PostDoStuffToWorkerPool(sequence_checked_object.get(), "B");
   PostDoStuffToWorkerPool(sequence_checked_object.get(), "B");
   pool()->FlushForTesting();
 
   PostDeleteToOtherThread(sequence_checked_object.Pass());
   other_thread()->Stop();
 }
 
 #if ENABLE_SEQUENCE_CHECKER
 TEST_F(SequenceCheckerTest, DifferentSequenceTokensDeathTestInDebug) {
+  // The default style "fast" does not support multi-threaded tests.
+  ::testing::FLAGS_gtest_death_test_style = "threadsafe";
   ASSERT_DEATH({
     DifferentSequenceTokensDeathTest();
   }, "");
 }
 #else
 TEST_F(SequenceCheckerTest,
      DifferentSequenceTokensDeathTestInRelease) {
   DifferentSequenceTokensDeathTest();
 }
 #endif  // ENABLE_SEQUENCE_CHECKER
 
 void SequenceCheckerTest::WorkerPoolAndSimpleThreadDeathTest() {
   scoped_ptr<SequenceCheckedObject> sequence_checked_object(
       new SequenceCheckedObject);
 
   sequence_checked_object->DetachFromSequence();
   PostDoStuffToWorkerPool(sequence_checked_object.get(), "A");
   PostDoStuffToWorkerPool(sequence_checked_object.get(), "A");
   pool()->FlushForTesting();
 
   PostDoStuffToOtherThread(sequence_checked_object.get());
   other_thread()->Stop();
 }
 
 #if ENABLE_SEQUENCE_CHECKER
 TEST_F(SequenceCheckerTest, WorkerPoolAndSimpleThreadDeathTestInDebug) {
+  // The default style "fast" does not support multi-threaded tests.
+  ::testing::FLAGS_gtest_death_test_style = "threadsafe";
   ASSERT_DEATH({
     WorkerPoolAndSimpleThreadDeathTest();
   }, "");
 }
 #else
 TEST_F(SequenceCheckerTest,
      WorkerPoolAndSimpleThreadDeathTestInRelease) {
   WorkerPoolAndSimpleThreadDeathTest();
 }
 #endif  // ENABLE_SEQUENCE_CHECKER
@@ skipping 12 matching lines @@
       "A",
       FROM_HERE,
       base::Bind(&SequenceCheckedObject::DoStuff,
                  base::Unretained(sequence_checked_object.get())));
   second_pool_owner.pool()->FlushForTesting();
   second_pool_owner.pool()->Shutdown();
 }
 
 #if ENABLE_SEQUENCE_CHECKER
 TEST_F(SequenceCheckerTest, TwoDifferentWorkerPoolsDeathTestInDebug) {
+  // The default style "fast" does not support multi-threaded tests.
+  ::testing::FLAGS_gtest_death_test_style = "threadsafe";
   ASSERT_DEATH({
     TwoDifferentWorkerPoolsDeathTest();
   }, "");
 }
 #else
 TEST_F(SequenceCheckerTest,
      TwoDifferentWorkerPoolsDeathTestInRelease) {
   TwoDifferentWorkerPoolsDeathTest();
 }
 #endif  // ENABLE_SEQUENCE_CHECKER
 
 #endif  // GTEST_HAS_DEATH_TEST || !ENABLE_SEQUENCE_CHECKER
 
 }  // namespace
 
 }  // namespace base
 
 // Just in case we ever get lumped together with other compilation units.
 #undef ENABLE_SEQUENCE_CHECKER