chrome/browser/profiles/profile_manager_unittest.cc - Issue 19616004: Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager_unittest.cc

Issue 19616004: Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add WARN_UNUSED_RESULT and assert_true in every caller. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bookmarks/bookmark_model_unittest.cc ('K') | « chrome/browser/predictors/resource_prefetch_predictor_unittest.cc ('k') | chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_manager_unittest.cc

diff --git a/chrome/browser/profiles/profile_manager_unittest.cc b/chrome/browser/profiles/profile_manager_unittest.cc

index 57ad93635e84003c1ac5f96cb5059ce539df6724..0241d0dc037cb3ed9a33e5cd15bfafa99ffc3b87 100644

--- a/chrome/browser/profiles/profile_manager_unittest.cc

+++ b/chrome/browser/profiles/profile_manager_unittest.cc

@@ -220,14 +220,14 @@ TEST_F(ProfileManagerTest, CreateAndUseTwoProfiles) {

ASSERT_TRUE(profile2);

// Force lazy-init of some profile services to simulate use.

- profile1->CreateHistoryService(true, false);

+ ASSERT_TRUE(profile1->CreateHistoryService(true, false));

EXPECT_TRUE(HistoryServiceFactory::GetForProfile(profile1,

Profile::EXPLICIT_ACCESS));

profile1->CreateBookmarkModel(true);

EXPECT_TRUE(BookmarkModelFactory::GetForProfile(profile1));

profile2->CreateBookmarkModel(true);

EXPECT_TRUE(BookmarkModelFactory::GetForProfile(profile2));

- profile2->CreateHistoryService(true, false);

+ ASSERT_TRUE(profile2->CreateHistoryService(true, false));

EXPECT_TRUE(HistoryServiceFactory::GetForProfile(profile2,

Profile::EXPLICIT_ACCESS));