Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted

chrome/browser/bookmarks/bookmark_model_unittest.cc

Index: chrome/browser/bookmarks/bookmark_model_unittest.cc
diff --git a/chrome/browser/bookmarks/bookmark_model_unittest.cc b/chrome/browser/bookmarks/bookmark_model_unittest.cc
index 06610d715c6c3f94f54829fdbef50248866c0e97..e66411f80ed86e4aaa2a3429e8340975f21fa36c 100644
--- a/chrome/browser/bookmarks/bookmark_model_unittest.cc
+++ b/chrome/browser/bookmarks/bookmark_model_unittest.cc
@@ -916,7 +916,7 @@ class BookmarkModelTestWithProfile : public testing::Test {
     // Need to shutdown the old one before creating a new one.
     profile_.reset(NULL);
     profile_.reset(new TestingProfile());
-    profile_->CreateHistoryService(true, false);
+    ASSERT_TRUE(profile_->CreateHistoryService(true, false));

[sky, 2013/07/22 23:02:23]

You need to wrap all calls to RecreateProfile() in ASSERT_NO_FATAL_FAILURE (or
promote the return value to the function itself and ASSERT there (assuming all
callers are SetUp/test-body, otherwise you'll have to continue propagating
return)). You'll want to do the same for all other places that aren't in
SetUp/test-body.

[rmcilroy, 2013/07/22 23:53:32]

This method was never actually used, so I removed it.  Done elsewhere
(history_url_provider_unittest.cc). Apologies for missing this first time round.

   }
 
   // The profile.
@@ -954,7 +954,7 @@ TEST_F(BookmarkModelTestWithProfile, CreateAndRestore) {
     profile_.reset(NULL);
     profile_.reset(new TestingProfile());
     profile_->CreateBookmarkModel(true);
-    profile_->CreateHistoryService(true, false);
+    ASSERT_TRUE(profile_->CreateHistoryService(true, false));
     BlockTillBookmarkModelLoaded();
 
     TestNode bbn;