Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1961563002:
Reduce some complexity in session_service_commands.cc (Closed)
|
Created:
4 years, 7 months ago by Tom (Use chromium acct) Modified:
4 years, 7 months ago Reviewers:
sky CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReduce some complexity in session_service_commands.cc
Committed: https://crrev.com/52983fe714a31c2c3378a0463f23d3461a818ce6
Cr-Commit-Position: refs/heads/master@{#392230}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Deprecated kCommandSetWindowWorkspace, removed memcpy #Patch Set 3 : Fix typo #Messages
Total messages: 22 (9 generated)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
thomasanderson@google.com changed reviewers: + sky@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961563002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1961563002/diff/1/components/sessions/core/se... File components/sessions/core/session_service_commands.cc (right): https://codereview.chromium.org/1961563002/diff/1/components/sessions/core/se... components/sessions/core/session_service_commands.cc:45: static const SessionCommand::id_type kCommandSetWindowWorkspace = 22; The format is now slightly different. You'll want to obsolete this like we did on line 22. Basically comment this line out and create a new one at 23. https://codereview.chromium.org/1961563002/diff/1/components/sessions/core/se... components/sessions/core/session_service_commands.cc:764: memcpy(command->contents(), pickle.data(), pickle.size()); This line shouldn't be necessary anymore.
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
https://codereview.chromium.org/1961563002/diff/1/components/sessions/core/se... File components/sessions/core/session_service_commands.cc (right): https://codereview.chromium.org/1961563002/diff/1/components/sessions/core/se... components/sessions/core/session_service_commands.cc:45: static const SessionCommand::id_type kCommandSetWindowWorkspace = 22; On 2016/05/06 21:31:49, sky wrote: > The format is now slightly different. You'll want to obsolete this like we did > on line 22. Basically comment this line out and create a new one at 23. Done. https://codereview.chromium.org/1961563002/diff/1/components/sessions/core/se... components/sessions/core/session_service_commands.cc:764: memcpy(command->contents(), pickle.data(), pickle.size()); On 2016/05/06 21:31:49, sky wrote: > This line shouldn't be necessary anymore. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961563002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961563002/40001
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961563002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Reduce some complexity in session_service_commands.cc ========== to ========== Reduce some complexity in session_service_commands.cc Committed: https://crrev.com/52983fe714a31c2c3378a0463f23d3461a818ce6 Cr-Commit-Position: refs/heads/master@{#392230} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/52983fe714a31c2c3378a0463f23d3461a818ce6 Cr-Commit-Position: refs/heads/master@{#392230} |
