Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1961433002: [Android] Move relocation_packer sources specification into gn. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Move relocation_packer sources specification into gn. BUG=609636 Committed: https://crrev.com/1cdc1b957aae6d011b05bacd788af0c056d9fdf6 Cr-Commit-Position: refs/heads/master@{#392327}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M third_party/android_platform/BUILD.gn View 4 chunks +37 lines, -9 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
4 years, 7 months ago (2016-05-06 01:37:11 UTC) #2
sgurun-gerrit only
lgtm https://codereview.chromium.org/1961433002/diff/1/third_party/android_platform/BUILD.gn File third_party/android_platform/BUILD.gn (right): https://codereview.chromium.org/1961433002/diff/1/third_party/android_platform/BUILD.gn#newcode70 third_party/android_platform/BUILD.gn:70: "bionic/tools/relocation_packer/src/debug_unittest.cc", curious, do these tests ever run on ...
4 years, 7 months ago (2016-05-06 17:46:32 UTC) #3
jbudorick
https://codereview.chromium.org/1961433002/diff/1/third_party/android_platform/BUILD.gn File third_party/android_platform/BUILD.gn (right): https://codereview.chromium.org/1961433002/diff/1/third_party/android_platform/BUILD.gn#newcode70 third_party/android_platform/BUILD.gn:70: "bionic/tools/relocation_packer/src/debug_unittest.cc", On 2016/05/06 17:46:32, sgurun wrote: > curious, do ...
4 years, 7 months ago (2016-05-09 15:04:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961433002/1
4 years, 7 months ago (2016-05-09 15:04:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 16:04:51 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 16:06:03 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1cdc1b957aae6d011b05bacd788af0c056d9fdf6
Cr-Commit-Position: refs/heads/master@{#392327}

Powered by Google App Engine
This is Rietveld 408576698