Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/android_platform/BUILD.gn

Issue 1961433002: [Android] Move relocation_packer sources specification into gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/android_platform/BUILD.gn
diff --git a/third_party/android_platform/BUILD.gn b/third_party/android_platform/BUILD.gn
index c0030d6b9109c99c28be56a2b1abdea640e0bd37..4d026c785c6e08a64ccdb07906e904eb9838f918 100644
--- a/third_party/android_platform/BUILD.gn
+++ b/third_party/android_platform/BUILD.gn
@@ -6,11 +6,6 @@ import("//testing/test.gni")
import("config.gni")
if (current_toolchain == host_toolchain) {
- gypi_values = exec_script("//build/gypi_to_gn.py",
- [ rebase_path("relocation_packer.gyp") ],
- "scope",
- [ "relocation_packer.gyp" ])
-
# GYP: //third_party/android_platform/relocation_packer.gyp:android_lib_relocation_packer
source_set("android_lib_relocation_packer") {
deps = [
@@ -18,7 +13,19 @@ if (current_toolchain == host_toolchain) {
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
- sources = gypi_values.relocation_packer_sources
+ sources = [
+ "bionic/tools/relocation_packer/src/debug.cc",
+ "bionic/tools/relocation_packer/src/debug.h",
+ "bionic/tools/relocation_packer/src/delta_encoder.cc",
+ "bionic/tools/relocation_packer/src/delta_encoder.h",
+ "bionic/tools/relocation_packer/src/elf_file.cc",
+ "bionic/tools/relocation_packer/src/elf_file.h",
+ "bionic/tools/relocation_packer/src/elf_traits.h",
+ "bionic/tools/relocation_packer/src/packer.cc",
+ "bionic/tools/relocation_packer/src/packer.h",
+ "bionic/tools/relocation_packer/src/sleb128.cc",
+ "bionic/tools/relocation_packer/src/sleb128.h",
+ ]
}
# GYP: //third_party/android_platform/relocation_packer.gyp:android_relocation_packer
@@ -28,11 +35,25 @@ if (current_toolchain == host_toolchain) {
"//build/config/sanitizers:deps",
"//third_party/elfutils:libelf",
]
- sources = gypi_values.relocation_packer_main_source
+ sources = [
+ "bionic/tools/relocation_packer/src/main.cc",
+ "bionic/tools/relocation_packer/src/nativehelper/ScopedFd.h",
+ ]
}
copy("copy_android_relocation_packer_test_data") {
- sources = gypi_values.relocation_packer_test_data_sources
+ sources = [
+ "bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm32.so",
+ "bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm32_packed.so",
+ "bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64.so",
+ "bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64_packed.so",
+ "bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_ia32.so",
+ "bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_ia32_packed.so",
+ "bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_mips32.so",
+ "bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_mips32_packed.so",
+ "bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_x64.so",
+ "bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_x64_packed.so",
+ ]
outputs = [
"$root_out_dir/{{source_file_part}}",
]
@@ -45,7 +66,14 @@ if (current_toolchain == host_toolchain) {
":copy_android_relocation_packer_test_data",
"//testing/gtest",
]
- sources = gypi_values.relocation_packer_test_sources
+ sources = [
+ "bionic/tools/relocation_packer/src/debug_unittest.cc",
sgurun-gerrit only 2016/05/06 17:46:32 curious, do these tests ever run on chromium side?
jbudorick 2016/05/09 15:04:08 Not currently.
+ "bionic/tools/relocation_packer/src/delta_encoder_unittest.cc",
+ "bionic/tools/relocation_packer/src/elf_file_unittest.cc",
+ "bionic/tools/relocation_packer/src/packer_unittest.cc",
+ "bionic/tools/relocation_packer/src/run_all_unittests.cc",
+ "bionic/tools/relocation_packer/src/sleb128_unittest.cc",
+ ]
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698