[heap] Do not invoke GC to make heap iterable.

[heap] Do not invoke GC to make heap iterable.

Remove kMakeHeapIterableMask since the heap is always iterable.

BUG=chromium:580959
LOG=n

Committed: https://crrev.com/7c1cac4888a248fda3fa6de3624f32a6babb37e9
Cr-Commit-Position: refs/heads/master@{#36333}

[Hannes Payer (out of office), 2016-05-10 13:51:33]

Description was changed from

==========
[heap] Remove kMakeHeapIterableMask since heap is always iterable.

BUG=chromium:580959
LOG=n
==========

to

==========
[heap] Do not invoke GC to make heap iterable.

Remove kMakeHeapIterableMask since the heap is always iterable.

BUG=chromium:580959
LOG=n
==========

[Hannes Payer (out of office), 2016-05-10 13:57:53]

hpayer@chromium.org changed reviewers:
+ ulan@chromium.org, yangguo@chromium.org

[Hannes Payer (out of office), 2016-05-10 13:57:53]

In a follow-up CL, I will change the heap iterate to be aware of the sweeper.
With that we can remove MakeHeapIterable.

[ulan, 2016-05-10 14:05:42]

lgtm with comments

https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snaps...
File src/profiler/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snaps...
src/profiler/heap-snapshot-generator.cc:481:
heap_->CollectAllGarbage(Heap::kNoGCFlags,
We probably need to about incremental marking here?

https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snaps...
src/profiler/heap-snapshot-generator.cc:2509:
"HeapSnapshotGenerator::GenerateSnapshot");
Abort incremental marking

https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snaps...
src/profiler/heap-snapshot-generator.cc:2510:
heap_->CollectAllGarbage(Heap::kNoGCFlags,
Abort incremental marking

[Yang, 2016-05-10 14:07:25]

lgtm

[Hannes Payer (out of office), 2016-05-18 14:49:48]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-05-18 14:49:49]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1961373003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-18 14:49:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961373003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961373003/40001

[Hannes Payer (out of office), 2016-05-18 14:50:14]

https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snaps...
File src/profiler/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snaps...
src/profiler/heap-snapshot-generator.cc:481:
heap_->CollectAllGarbage(Heap::kNoGCFlags,
On 2016/05/10 at 14:05:42, ulan wrote:
> We probably need to about incremental marking here?

Done.

https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snaps...
src/profiler/heap-snapshot-generator.cc:2509:
"HeapSnapshotGenerator::GenerateSnapshot");
On 2016/05/10 at 14:05:41, ulan wrote:
> Abort incremental marking


Done.

https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snaps...
src/profiler/heap-snapshot-generator.cc:2510:
heap_->CollectAllGarbage(Heap::kNoGCFlags,
On 2016/05/10 at 14:05:42, ulan wrote:
> Abort incremental marking


Done.

[commit-bot: I haz the power, 2016-05-18 15:15:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 15:16:00]

Try jobs failed on following builders:
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5915)
  v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Hannes Payer (out of office), 2016-05-18 18:00:00]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-05-18 18:00:00]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1961373003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-18 18:00:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961373003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961373003/80001

[commit-bot: I haz the power, 2016-05-18 18:02:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-18 18:03:56]

Description was changed from

==========
[heap] Do not invoke GC to make heap iterable.

Remove kMakeHeapIterableMask since the heap is always iterable.

BUG=chromium:580959
LOG=n
==========

to

==========
[heap] Do not invoke GC to make heap iterable.

Remove kMakeHeapIterableMask since the heap is always iterable.

BUG=chromium:580959
LOG=n

Committed: https://crrev.com/7c1cac4888a248fda3fa6de3624f32a6babb37e9
Cr-Commit-Position: refs/heads/master@{#36333}
==========

[commit-bot: I haz the power, 2016-05-18 18:03:57]

Patchset 5 (id:??) landed as
https://crrev.com/7c1cac4888a248fda3fa6de3624f32a6babb37e9
Cr-Commit-Position: refs/heads/master@{#36333}

[Michael Achenbach, 2016-05-18 19:21:44]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1987363002/ by machenbach@chromium.org.

The reason for reverting is: Breaks
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/....