Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1961343003: Use [[DefineOwnProperty]] when converting IDL array values (Closed)

Created:
4 years, 7 months ago by Jens Widell
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Use [[DefineOwnProperty]] when converting IDL array values This means using v8::Object::CreateDataProperty() rather than Set(), and is in line with how the conversion is defined in WebIDL. The incorrect use of Set() is observable by scripts that define setters on Array.prototype for the properties "0", "1", "2" and so on. Also apply the same fix to conversion of Vector<std::pair<>> into object. BUG=607483 Review-Url: https://codereview.chromium.org/1936433002 Cr-Commit-Position: refs/heads/master@{#390610} (cherry picked from commit 650cd4ace843e976e28fa87fa40bd9c017d39f63) Committed: https://chromium.googlesource.com/chromium/src/+/010f3edb08426c16a4374dd13e25ff3538fb43dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/js/webidl-sequence-conversion.html View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jens Widell
4 years, 7 months ago (2016-05-10 11:14:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
010f3edb08426c16a4374dd13e25ff3538fb43dc.

Powered by Google App Engine
This is Rietveld 408576698