Chromium Code Reviews
DescriptionUse [[DefineOwnProperty]] when converting IDL array values
This means using v8::Object::CreateDataProperty() rather than Set(), and
is in line with how the conversion is defined in WebIDL. The incorrect use
of Set() is observable by scripts that define setters on Array.prototype
for the properties "0", "1", "2" and so on.
Also apply the same fix to conversion of Vector<std::pair<>> into object.
BUG=607483
Review-Url: https://codereview.chromium.org/1936433002
Cr-Commit-Position: refs/heads/master@{#390610}
(cherry picked from commit 650cd4ace843e976e28fa87fa40bd9c017d39f63)
Committed: https://chromium.googlesource.com/chromium/src/+/010f3edb08426c16a4374dd13e25ff3538fb43dc
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||