Use [[DefineOwnProperty]] when converting IDL array values

Use [[DefineOwnProperty]] when converting IDL array values

This means using v8::Object::CreateDataProperty() rather than Set(), and
is in line with how the conversion is defined in WebIDL. The incorrect use
of Set() is observable by scripts that define setters on Array.prototype
for the properties "0", "1", "2" and so on.

Also apply the same fix to conversion of Vector<std::pair<>> into object.

BUG=607483
Committed: https://crrev.com/650cd4ace843e976e28fa87fa40bd9c017d39f63
Cr-Commit-Position: refs/heads/master@{#390610}

[Jens Widell, 2016-04-29 08:12:05]

jl@opera.com changed reviewers:
+ haraken@chromium.org, yukishiino@chromium.org

[Jens Widell, 2016-04-29 08:12:06]

PTAL

This CL independently fixes the TC in bug 607483.

[haraken, 2016-04-29 08:46:01]

LGTM

[Jens Widell, 2016-04-29 08:52:53]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2016-04-29 08:53:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936433002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936433002/1

[commit-bot: I haz the power, 2016-04-29 10:08:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:24:50]

Patchset 1 (id:??) landed as
https://crrev.com/650cd4ace843e976e28fa87fa40bd9c017d39f63
Cr-Commit-Position: refs/heads/master@{#390610}

[commit-bot: I haz the power, 2016-04-30 17:59:59]

Description was changed from

==========
Use [[DefineOwnProperty]] when converting IDL array values

This means using v8::Object::CreateDataProperty() rather than Set(), and
is in line with how the conversion is defined in WebIDL. The incorrect use
of Set() is observable by scripts that define setters on Array.prototype
for the properties "0", "1", "2" and so on.

Also apply the same fix to conversion of Vector<std::pair<>> into object.

BUG=607483
==========

to

==========
Use [[DefineOwnProperty]] when converting IDL array values

This means using v8::Object::CreateDataProperty() rather than Set(), and
is in line with how the conversion is defined in WebIDL. The incorrect use
of Set() is observable by scripts that define setters on Array.prototype
for the properties "0", "1", "2" and so on.

Also apply the same fix to conversion of Vector<std::pair<>> into object.

BUG=607483

Committed: https://crrev.com/650cd4ace843e976e28fa87fa40bd9c017d39f63
Cr-Commit-Position: refs/heads/master@{#390610}
==========

[Yuki, 2016-05-09 05:52:23]

LGTM.