Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1961343002: Adjust constness to avoid const_cast. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae, szager1, wkorman
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust constness to avoid const_cast. Committed: https://crrev.com/c8fc284b7d051d7701ea5113c8aa274abe842ccd Cr-Commit-Position: refs/heads/master@{#392642}

Patch Set 1 #

Patch Set 2 : LayoutBlock::enclosingFirstLineStyleBlock() also had a const_cast that can be eliminated easily. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 chunks +4 lines, -4 lines 4 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-10 10:49:39 UTC) #2
eae
https://codereview.chromium.org/1961343002/diff/20001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right): https://codereview.chromium.org/1961343002/diff/20001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp#newcode2027 third_party/WebKit/Source/core/layout/LayoutBlock.cpp:2027: LayoutBlockFlow* LayoutBlock::nearestInnerBlockWithFirstLine() Can this return a const LayoutBlockFlow? https://codereview.chromium.org/1961343002/diff/20001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp#newcode2030 ...
4 years, 7 months ago (2016-05-10 15:40:54 UTC) #4
mstensho (USE GERRIT)
https://codereview.chromium.org/1961343002/diff/20001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right): https://codereview.chromium.org/1961343002/diff/20001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp#newcode2027 third_party/WebKit/Source/core/layout/LayoutBlock.cpp:2027: LayoutBlockFlow* LayoutBlock::nearestInnerBlockWithFirstLine() On 2016/05/10 15:40:54, eae wrote: > Can ...
4 years, 7 months ago (2016-05-10 15:58:17 UTC) #5
eae
ok, thanks for the clarifications LGTM
4 years, 7 months ago (2016-05-10 15:59:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961343002/20001
4 years, 7 months ago (2016-05-10 16:26:57 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 17:52:48 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 17:55:26 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c8fc284b7d051d7701ea5113c8aa274abe842ccd
Cr-Commit-Position: refs/heads/master@{#392642}

Powered by Google App Engine
This is Rietveld 408576698