third_party/WebKit/Source/core/layout/LayoutBlock.h - Issue 1961343002: Adjust constness to avoid const_cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1961343002: Adjust constness to avoid const_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: LayoutBlock::enclosingFirstLineStyleBlock() also had a const_cast that can be eliminated easily. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h

index 10fb3ac050f007fcc526282aaf44b9835859037c..c0e7e50fc9ad90455c46f65b30712d77cc6dde30 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h

@@ -276,9 +276,9 @@ public:

// </div>

// Returns the nearest enclosing block (including this block) that contributes a first-line style to our first line.

- LayoutBlock* enclosingFirstLineStyleBlock() const;

+ const LayoutBlock* enclosingFirstLineStyleBlock() const;

// Returns this block or the nearest inner block containing the actual first line.

- LayoutBlockFlow* nearestInnerBlockWithFirstLine() const;

+ LayoutBlockFlow* nearestInnerBlockWithFirstLine();

protected:

void willBeDestroyed() override;