replace old SK_TRACE_EVENT macros with new TRACE_EVENT ones

replace old SK_TRACE_EVENT macros with new TRACE_EVENT ones, and then remove them entirely!

BUG=skia:353
Committed: http://code.google.com/p/skia/source/detail?r=13884

[humper, 2014-03-19 21:28:05]

ptal, can close very old bug when this lands!

[epoger, 2014-03-19 21:31:42]

Edited the description to contain
BUG=skia:353
instead of
BUG=353

Looking at the CL now...

[epoger, 2014-03-19 21:34:44]

Looks fine except for one question...

https://codereview.chromium.org/196133033/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/196133033/diff/1/src/gpu/GrContext.cpp#newcod...
src/gpu/GrContext.cpp:374:
TRACE_EVENT0("skia.ganesh","GrContext::createTexture");
Should we use a macro or constant for the recurring "skia" and "skia.ganesh"
string values?  That way we would catch typos at compile time...

[tomhudson, 2014-03-20 08:52:17]

On 2014/03/19 21:34:44, epoger wrote:
>
https://codereview.chromium.org/196133033/diff/1/src/gpu/GrContext.cpp#newcod...
> src/gpu/GrContext.cpp:374:
> TRACE_EVENT0("skia.ganesh","GrContext::createTexture");
> Should we use a macro or constant for the recurring "skia" and "skia.ganesh"
> string values?  That way we would catch typos at compile time...

Compositor has shifted to doing that for names that need to be well-known and
stable because they're read by external profiling tools, so it's a common
pattern in Chromium.

[bsalomon, 2014-03-20 13:26:24]

IMO we should just delete the current events. Greg D. has a change in the works
that will add a new macro that inserts a Trace Event and a GL debug marker. It
builds on top of SkTraceEvent.h I think we should just start with a clean slate
and use the new macro once it has landed.

[humper, 2014-03-20 16:52:19]

On 2014/03/20 13:26:24, bsalomon wrote:
> IMO we should just delete the current events. Greg D. has a change in the
works
> that will add a new macro that inserts a Trace Event and a GL debug marker. It
> builds on top of SkTraceEvent.h I think we should just start with a clean
slate
> and use the new macro once it has landed.

I think this is a great idea.  Old events removed.

[epoger, 2014-03-20 17:08:29]

[deferring to bsalomon]

[bsalomon, 2014-03-20 19:23:49]

lgtm

[humper, 2014-03-20 19:25:16]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-03-20 19:25:27]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/196133033/20001

[commit-bot: I haz the power, 2014-03-20 20:00:37]

Change committed as 13884