| Index: src/a64/assembler-a64-inl.h
|
| diff --git a/src/a64/assembler-a64-inl.h b/src/a64/assembler-a64-inl.h
|
| index e68dee073822f0c56e03b05c19ec44a35f305951..2a930b2e7dcef3b76413f0290b232f03d650d616 100644
|
| --- a/src/a64/assembler-a64-inl.h
|
| +++ b/src/a64/assembler-a64-inl.h
|
| @@ -44,7 +44,7 @@ void RelocInfo::apply(intptr_t delta) {
|
|
|
| void RelocInfo::set_target_address(Address target, WriteBarrierMode mode) {
|
| ASSERT(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
|
| - Assembler::set_target_address_at(pc_, target);
|
| + Assembler::set_target_address_at(pc_, host_, target);
|
| if (mode == UPDATE_WRITE_BARRIER && host() != NULL && IsCodeTarget(rmode_)) {
|
| Object* target_code = Code::GetCodeFromTargetAddress(target);
|
| host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
|
| @@ -109,14 +109,14 @@ inline bool CPURegister::IsValid() const {
|
|
|
| inline bool CPURegister::IsValidRegister() const {
|
| return IsRegister() &&
|
| - ((reg_size == kWRegSize) || (reg_size == kXRegSize)) &&
|
| + ((reg_size == kWRegSizeInBits) || (reg_size == kXRegSizeInBits)) &&
|
| ((reg_code < kNumberOfRegisters) || (reg_code == kSPRegInternalCode));
|
| }
|
|
|
|
|
| inline bool CPURegister::IsValidFPRegister() const {
|
| return IsFPRegister() &&
|
| - ((reg_size == kSRegSize) || (reg_size == kDRegSize)) &&
|
| + ((reg_size == kSRegSizeInBits) || (reg_size == kDRegSizeInBits)) &&
|
| (reg_code < kNumberOfFPRegisters);
|
| }
|
|
|
| @@ -179,9 +179,9 @@ inline void CPURegList::Combine(const CPURegList& other) {
|
|
|
| inline void CPURegList::Remove(const CPURegList& other) {
|
| ASSERT(IsValid());
|
| - ASSERT(other.type() == type_);
|
| - ASSERT(other.RegisterSizeInBits() == size_);
|
| - list_ &= ~other.list();
|
| + if (other.type() == type_) {
|
| + list_ &= ~other.list();
|
| + }
|
| }
|
|
|
|
|
| @@ -192,10 +192,14 @@ inline void CPURegList::Combine(const CPURegister& other) {
|
| }
|
|
|
|
|
| -inline void CPURegList::Remove(const CPURegister& other) {
|
| - ASSERT(other.type() == type_);
|
| - ASSERT(other.SizeInBits() == size_);
|
| - Remove(other.code());
|
| +inline void CPURegList::Remove(const CPURegister& other1,
|
| + const CPURegister& other2,
|
| + const CPURegister& other3,
|
| + const CPURegister& other4) {
|
| + if (!other1.IsNone() && (other1.type() == type_)) Remove(other1.code());
|
| + if (!other2.IsNone() && (other2.type() == type_)) Remove(other2.code());
|
| + if (!other3.IsNone() && (other3.type() == type_)) Remove(other3.code());
|
| + if (!other4.IsNone() && (other4.type() == type_)) Remove(other4.code());
|
| }
|
|
|
|
|
| @@ -217,25 +221,25 @@ inline Register Register::XRegFromCode(unsigned code) {
|
| // This function returns the zero register when code = 31. The stack pointer
|
| // can not be returned.
|
| ASSERT(code < kNumberOfRegisters);
|
| - return Register::Create(code, kXRegSize);
|
| + return Register::Create(code, kXRegSizeInBits);
|
| }
|
|
|
|
|
| inline Register Register::WRegFromCode(unsigned code) {
|
| ASSERT(code < kNumberOfRegisters);
|
| - return Register::Create(code, kWRegSize);
|
| + return Register::Create(code, kWRegSizeInBits);
|
| }
|
|
|
|
|
| inline FPRegister FPRegister::SRegFromCode(unsigned code) {
|
| ASSERT(code < kNumberOfFPRegisters);
|
| - return FPRegister::Create(code, kSRegSize);
|
| + return FPRegister::Create(code, kSRegSizeInBits);
|
| }
|
|
|
|
|
| inline FPRegister FPRegister::DRegFromCode(unsigned code) {
|
| ASSERT(code < kNumberOfFPRegisters);
|
| - return FPRegister::Create(code, kDRegSize);
|
| + return FPRegister::Create(code, kDRegSizeInBits);
|
| }
|
|
|
|
|
| @@ -330,8 +334,8 @@ Operand::Operand(Register reg, Shift shift, unsigned shift_amount)
|
| extend_(NO_EXTEND),
|
| shift_amount_(shift_amount),
|
| rmode_(reg.Is64Bits() ? RelocInfo::NONE64 : RelocInfo::NONE32) {
|
| - ASSERT(reg.Is64Bits() || (shift_amount < kWRegSize));
|
| - ASSERT(reg.Is32Bits() || (shift_amount < kXRegSize));
|
| + ASSERT(reg.Is64Bits() || (shift_amount < kWRegSizeInBits));
|
| + ASSERT(reg.Is32Bits() || (shift_amount < kXRegSizeInBits));
|
| ASSERT(!reg.IsSP());
|
| }
|
|
|
| @@ -554,11 +558,18 @@ Address Assembler::target_pointer_address_at(Address pc) {
|
|
|
|
|
| // Read/Modify the code target address in the branch/call instruction at pc.
|
| -Address Assembler::target_address_at(Address pc) {
|
| +Address Assembler::target_address_at(Address pc,
|
| + ConstantPoolArray* constant_pool) {
|
| return Memory::Address_at(target_pointer_address_at(pc));
|
| }
|
|
|
|
|
| +Address Assembler::target_address_at(Address pc, Code* code) {
|
| + ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL;
|
| + return target_address_at(pc, constant_pool);
|
| +}
|
| +
|
| +
|
| Address Assembler::target_address_from_return_address(Address pc) {
|
| // Returns the address of the call target from the return address that will
|
| // be returned to after a call.
|
| @@ -612,12 +623,14 @@ Address Assembler::return_address_from_call_start(Address pc) {
|
|
|
|
|
| void Assembler::deserialization_set_special_target_at(
|
| - Address constant_pool_entry, Address target) {
|
| + Address constant_pool_entry, Code* code, Address target) {
|
| Memory::Address_at(constant_pool_entry) = target;
|
| }
|
|
|
|
|
| -void Assembler::set_target_address_at(Address pc, Address target) {
|
| +void Assembler::set_target_address_at(Address pc,
|
| + ConstantPoolArray* constant_pool,
|
| + Address target) {
|
| Memory::Address_at(target_pointer_address_at(pc)) = target;
|
| // Intuitively, we would think it is necessary to always flush the
|
| // instruction cache after patching a target address in the code as follows:
|
| @@ -630,6 +643,14 @@ void Assembler::set_target_address_at(Address pc, Address target) {
|
| }
|
|
|
|
|
| +void Assembler::set_target_address_at(Address pc,
|
| + Code* code,
|
| + Address target) {
|
| + ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL;
|
| + set_target_address_at(pc, constant_pool, target);
|
| +}
|
| +
|
| +
|
| int RelocInfo::target_address_size() {
|
| return kPointerSize;
|
| }
|
| @@ -637,7 +658,7 @@ int RelocInfo::target_address_size() {
|
|
|
| Address RelocInfo::target_address() {
|
| ASSERT(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
|
| - return Assembler::target_address_at(pc_);
|
| + return Assembler::target_address_at(pc_, host_);
|
| }
|
|
|
|
|
| @@ -649,23 +670,30 @@ Address RelocInfo::target_address_address() {
|
| }
|
|
|
|
|
| +Address RelocInfo::constant_pool_entry_address() {
|
| + ASSERT(IsInConstantPool());
|
| + return Assembler::target_pointer_address_at(pc_);
|
| +}
|
| +
|
| +
|
| Object* RelocInfo::target_object() {
|
| ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
|
| - return reinterpret_cast<Object*>(Assembler::target_address_at(pc_));
|
| + return reinterpret_cast<Object*>(Assembler::target_address_at(pc_, host_));
|
| }
|
|
|
|
|
| Handle<Object> RelocInfo::target_object_handle(Assembler* origin) {
|
| ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
|
| return Handle<Object>(reinterpret_cast<Object**>(
|
| - Assembler::target_address_at(pc_)));
|
| + Assembler::target_address_at(pc_, host_)));
|
| }
|
|
|
|
|
| void RelocInfo::set_target_object(Object* target, WriteBarrierMode mode) {
|
| ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
|
| ASSERT(!target->IsConsString());
|
| - Assembler::set_target_address_at(pc_, reinterpret_cast<Address>(target));
|
| + Assembler::set_target_address_at(pc_, host_,
|
| + reinterpret_cast<Address>(target));
|
| if (mode == UPDATE_WRITE_BARRIER &&
|
| host() != NULL &&
|
| target->IsHeapObject()) {
|
| @@ -677,7 +705,7 @@ void RelocInfo::set_target_object(Object* target, WriteBarrierMode mode) {
|
|
|
| Address RelocInfo::target_reference() {
|
| ASSERT(rmode_ == EXTERNAL_REFERENCE);
|
| - return Assembler::target_address_at(pc_);
|
| + return Assembler::target_address_at(pc_, host_);
|
| }
|
|
|
|
|
| @@ -746,14 +774,14 @@ Address RelocInfo::call_address() {
|
| (IsDebugBreakSlot(rmode()) && IsPatchedDebugBreakSlotSequence()));
|
| // For the above sequences the Relocinfo points to the load literal loading
|
| // the call address.
|
| - return Assembler::target_address_at(pc_);
|
| + return Assembler::target_address_at(pc_, host_);
|
| }
|
|
|
|
|
| void RelocInfo::set_call_address(Address target) {
|
| ASSERT((IsJSReturn(rmode()) && IsPatchedReturnSequence()) ||
|
| (IsDebugBreakSlot(rmode()) && IsPatchedDebugBreakSlotSequence()));
|
| - Assembler::set_target_address_at(pc_, target);
|
| + Assembler::set_target_address_at(pc_, host_, target);
|
| if (host() != NULL) {
|
| Object* target_code = Code::GetCodeFromTargetAddress(target);
|
| host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
|
| @@ -767,7 +795,7 @@ void RelocInfo::WipeOut() {
|
| IsCodeTarget(rmode_) ||
|
| IsRuntimeEntry(rmode_) ||
|
| IsExternalReference(rmode_));
|
| - Assembler::set_target_address_at(pc_, NULL);
|
| + Assembler::set_target_address_at(pc_, host_, NULL);
|
| }
|
|
|
|
|
| @@ -996,16 +1024,16 @@ Instr Assembler::ImmAddSub(int64_t imm) {
|
|
|
|
|
| Instr Assembler::ImmS(unsigned imms, unsigned reg_size) {
|
| - ASSERT(((reg_size == kXRegSize) && is_uint6(imms)) ||
|
| - ((reg_size == kWRegSize) && is_uint5(imms)));
|
| + ASSERT(((reg_size == kXRegSizeInBits) && is_uint6(imms)) ||
|
| + ((reg_size == kWRegSizeInBits) && is_uint5(imms)));
|
| USE(reg_size);
|
| return imms << ImmS_offset;
|
| }
|
|
|
|
|
| Instr Assembler::ImmR(unsigned immr, unsigned reg_size) {
|
| - ASSERT(((reg_size == kXRegSize) && is_uint6(immr)) ||
|
| - ((reg_size == kWRegSize) && is_uint5(immr)));
|
| + ASSERT(((reg_size == kXRegSizeInBits) && is_uint6(immr)) ||
|
| + ((reg_size == kWRegSizeInBits) && is_uint5(immr)));
|
| USE(reg_size);
|
| ASSERT(is_uint6(immr));
|
| return immr << ImmR_offset;
|
| @@ -1013,18 +1041,18 @@ Instr Assembler::ImmR(unsigned immr, unsigned reg_size) {
|
|
|
|
|
| Instr Assembler::ImmSetBits(unsigned imms, unsigned reg_size) {
|
| - ASSERT((reg_size == kWRegSize) || (reg_size == kXRegSize));
|
| + ASSERT((reg_size == kWRegSizeInBits) || (reg_size == kXRegSizeInBits));
|
| ASSERT(is_uint6(imms));
|
| - ASSERT((reg_size == kXRegSize) || is_uint6(imms + 3));
|
| + ASSERT((reg_size == kXRegSizeInBits) || is_uint6(imms + 3));
|
| USE(reg_size);
|
| return imms << ImmSetBits_offset;
|
| }
|
|
|
|
|
| Instr Assembler::ImmRotate(unsigned immr, unsigned reg_size) {
|
| - ASSERT((reg_size == kWRegSize) || (reg_size == kXRegSize));
|
| - ASSERT(((reg_size == kXRegSize) && is_uint6(immr)) ||
|
| - ((reg_size == kWRegSize) && is_uint5(immr)));
|
| + ASSERT((reg_size == kWRegSizeInBits) || (reg_size == kXRegSizeInBits));
|
| + ASSERT(((reg_size == kXRegSizeInBits) && is_uint6(immr)) ||
|
| + ((reg_size == kWRegSizeInBits) && is_uint5(immr)));
|
| USE(reg_size);
|
| return immr << ImmRotate_offset;
|
| }
|
| @@ -1037,8 +1065,8 @@ Instr Assembler::ImmLLiteral(int imm19) {
|
|
|
|
|
| Instr Assembler::BitN(unsigned bitn, unsigned reg_size) {
|
| - ASSERT((reg_size == kWRegSize) || (reg_size == kXRegSize));
|
| - ASSERT((reg_size == kXRegSize) || (bitn == 0));
|
| + ASSERT((reg_size == kWRegSizeInBits) || (reg_size == kXRegSizeInBits));
|
| + ASSERT((reg_size == kXRegSizeInBits) || (bitn == 0));
|
| USE(reg_size);
|
| return bitn << BitN_offset;
|
| }
|
| @@ -1178,7 +1206,10 @@ inline void Assembler::CheckBuffer() {
|
| if (buffer_space() < kGap) {
|
| GrowBuffer();
|
| }
|
| - if (pc_offset() >= next_buffer_check_) {
|
| + if (pc_offset() >= next_veneer_pool_check_) {
|
| + CheckVeneerPool(true);
|
| + }
|
| + if (pc_offset() >= next_constant_pool_check_) {
|
| CheckConstPool(false, true);
|
| }
|
| }
|
|
|