chrome/browser/ui/views/toolbar/toolbar_button.cc - Issue 196133012: Fix incorrect use of AXState caused when refactoring two enums into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.cc

Issue 196133012: Fix incorrect use of AXState caused when refactoring two enums into one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename SetStateFlag -> AddStateFlag Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/toolbar/toolbar_button.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.cc b/chrome/browser/ui/views/toolbar/toolbar_button.cc

index fb97d1c1642e708fe05d5bcc609d6627a97a6dfb..fd8d239b7f456d12d05ef0e828a5530891293b5e 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_button.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_button.cc

@@ -125,7 +125,7 @@ void ToolbarButton::GetAccessibleState(ui::AXViewState* state) {

CustomButton::GetAccessibleState(state);

state->role = ui::AX_ROLE_BUTTON_DROP_DOWN;

state->default_action = l10n_util::GetStringUTF16(IDS_APP_ACCACTION_PRESS);

- state->state = ui::AX_STATE_HASPOPUP;

+ state->AddStateFlag(ui::AX_STATE_HASPOPUP);

}

void ToolbarButton::ShowContextMenuForView(View* source,

« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | ui/accessibility/ax_view_state.h » ('j') | no next file with comments »